Trim whitespace when parsing entries

[tablify] / src / lib.rs

diff --git a/src/lib.rs b/src/lib.rs
index bebbcf799792f0de82ad9d65bbe8543a0ddda01b..5b06e705aecaaac8fd071f064dd63d731038687d 100644 (file)
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -41,13 +41,19 @@ const FOOTER: &str = "    </tbody>
 #[derive(Debug, PartialEq, Eq, Hash)]
 struct Entry {
     col: String,
-    instance: String,
+    instance: Option<String>,
 }
 impl From<&str> for Entry {
     fn from(value: &str) -> Entry {
-        Entry {
-            col: String::from(value),
-            instance: String::from(""),
+        match value.split_once(':') {
+            None => Entry {
+                col: String::from(value),
+                instance: None,
+            },
+            Some((col, instance)) => Entry {
+                col: String::from(col.trim()),
+                instance: Some(String::from(instance.trim())),
+            },
         }
     }
 }
@@ -116,9 +122,15 @@ fn read_rows(input: impl std::io::Read) -> impl Iterator<Item = Result<RowInput,
 fn column_counts(rows: &[RowInput]) -> Vec<(usize, String)> {
     let mut counts: Vec<_> = rows
         .iter()
-        .flat_map(|r| r.entries.iter().collect::<HashSet<_>>().into_iter())
-        .fold(HashMap::new(), |mut cs, e| {
-            cs.entry(String::from(&e.col))
+        .flat_map(|r| {
+            r.entries
+                .iter()
+                .map(|e| &e.col)
+                .collect::<HashSet<_>>()
+                .into_iter()
+        })
+        .fold(HashMap::new(), |mut cs, col| {
+            cs.entry(String::from(col))
                 .and_modify(|n| *n += 1)
                 .or_insert(1);
             cs
@@ -146,6 +158,31 @@ pub fn tablify(input: impl std::io::Read) -> Result<String, std::io::Error> {
 mod tests {
     use super::*;
 
+    #[test]
+    fn test_parse_entry() {
+        assert_eq!(
+            Entry::from("foo"),
+            Entry {
+                col: String::from("foo"),
+                instance: None
+            }
+        );
+        assert_eq!(
+            Entry::from("foo:bar"),
+            Entry {
+                col: String::from("foo"),
+                instance: Some(String::from("bar"))
+            }
+        );
+        assert_eq!(
+            Entry::from("foo: bar"),
+            Entry {
+                col: String::from("foo"),
+                instance: Some(String::from("bar"))
+            }
+        );
+    }
+
     #[test]
     fn test_read_rows() {
         assert_eq!(
@@ -266,5 +303,13 @@ mod tests {
             ),
             vec![(1, String::from("bar")), (2, String::from("baz"))]
         );
+        assert_eq!(
+            column_counts(
+                &read_rows(&b"foo\n bar: 1\n bar: 2\n baz\n bar\nquux\n baz"[..])
+                    .collect::<Result<Vec<_>, _>>()
+                    .unwrap()
+            ),
+            vec![(1, String::from("bar")), (2, String::from("baz"))]
+        );
     }
 }