Don't emit useless `class=""`

[tablify] / src / lib.rs

diff --git a/src/lib.rs b/src/lib.rs
index 99c454dc5ad83fd1c80acb3362b855f470065426..d85de02dda58b9cbbe1d077d5bd485851d255946 100644 (file)
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -4,10 +4,18 @@ use std::fmt::Write;
 use std::io::BufRead;
 use std::iter::Iterator;
 
 use std::io::BufRead;
 use std::iter::Iterator;
 

+fn tally_marks(n: usize) -> String {
+    let fives = { 0..n / 5 }.map(|_| '𝍸');
+    let ones = { 0..n % 5 }.map(|_| '𝍷');
+    fives.chain(ones).collect()
+}
+

 #[derive(PartialEq, Eq, Debug)]
 struct Config {
     column_threshold: usize,
     static_columns: Vec<Option<String>>,
 #[derive(PartialEq, Eq, Debug)]
 struct Config {
     column_threshold: usize,
     static_columns: Vec<Option<String>>,

+    hidden_columns: HashSet<String>,
+    substitute_labels: HashMap<String, String>,

 }
 impl Config {
     fn apply_command(&mut self, line_num: usize, cmd: &str) -> Result<(), std::io::Error> {
 }
 impl Config {
     fn apply_command(&mut self, line_num: usize, cmd: &str) -> Result<(), std::io::Error> {


@@ -18,10 +26,24 @@ impl Config {
                     format!("line {line_num}: col_threshold must be numeric: {e}"),
                 )
             })?;
                     format!("line {line_num}: col_threshold must be numeric: {e}"),
                 )
             })?;

+        } else if let Some(col) = cmd.strip_prefix("hide ") {
+            self.hidden_columns.insert(col.to_owned());

         } else if let Some(col) = cmd.strip_prefix("col ") {
             self.static_columns.push(Some(col.to_owned()));
         } else if cmd == "colsep" {
             self.static_columns.push(None);
         } else if let Some(col) = cmd.strip_prefix("col ") {
             self.static_columns.push(Some(col.to_owned()));
         } else if cmd == "colsep" {
             self.static_columns.push(None);

+        } else if let Some(directive) = cmd.strip_prefix("label ") {
+            match directive.split_once(':') {
+                None => {
+                    return Err(std::io::Error::new(
+                        std::io::ErrorKind::InvalidInput,
+                        format!("line {line_num}: Annotation missing ':'"),
+                    ))
+                }
+                Some((col, label)) => self
+                    .substitute_labels
+                    .insert(col.to_owned(), label.to_owned()),
+            };

         } else {
             return Err(std::io::Error::new(
                 std::io::ErrorKind::InvalidInput,
         } else {
             return Err(std::io::Error::new(
                 std::io::ErrorKind::InvalidInput,


@@ -36,6 +58,8 @@ impl Default for Config {
         Self {
             column_threshold: 2,
             static_columns: vec![],
         Self {
             column_threshold: 2,
             static_columns: vec![],

+            hidden_columns: HashSet::new(),
+            substitute_labels: HashMap::new(),

         }
     }
 }
         }
     }
 }


@@ -253,63 +277,78 @@ fn column_order(config: &Config, rows: &[Rowlike]) -> Vec<String> {
     column_counts(rows)
         .into_iter()
         .filter_map(|(n, col)| {
     column_counts(rows)
         .into_iter()
         .filter_map(|(n, col)| {

-            (n >= config.column_threshold && !static_columns.contains(col.as_str())).then_some(col)
+            (n >= config.column_threshold
+                && !static_columns.contains(col.as_str())
+                && !config.hidden_columns.contains(&col))
+            .then_some(col)

         })
         .collect()
 }
 
         })
         .collect()
 }
 

-fn render_one_instance(instance: &Option<String>) -> HTML {
-    match instance {
-        None => HTML::from("✓"),
-        Some(instance) => HTML::escape(instance.as_ref()),
-    }
-}
-

 fn render_instances(instances: &[Option<String>]) -> HTML {
 fn render_instances(instances: &[Option<String>]) -> HTML {

-    let all_empty = instances.iter().all(Option::is_none);
-    if all_empty && instances.len() == 1 {
-        HTML::from("")
-    } else if all_empty {
-        HTML(format!("{}", instances.len()))
-    } else {
-        HTML(
-            instances
-                .iter()
-                .map(render_one_instance)
-                .map(|html| html.0) // Waiting for slice_concat_trait to stabilize
-                .collect::<Vec<_>>()
-                .join(" "),
-        )
+    let mut tally = 0;
+    let mut out = vec![];
+    for ins in instances {
+        match ins {
+            None => tally += 1,
+            Some(content) => {
+                if tally > 0 {
+                    out.push(HTML(tally_marks(tally)));
+                    tally = 0;
+                }
+                out.push(HTML::escape(content));
+            }
+        }
+    }
+    if tally > 0 {
+        out.push(HTML(tally_marks(tally)));

     }
     }

+    HTML(
+        out.into_iter()
+            .map(|html| html.0) // Waiting for slice_concat_trait to stabilize
+            .collect::<Vec<_>>()
+            .join(" "),
+    )

 }
 
 fn render_cell(col: &str, row: &mut Row) -> HTML {
     let row_label = HTML::escape(row.label.as_ref());
     let col_label = HTML::escape(col);
     let instances: Option<&Vec<Option<String>>> = row.entries.get(col);
 }
 
 fn render_cell(col: &str, row: &mut Row) -> HTML {
     let row_label = HTML::escape(row.label.as_ref());
     let col_label = HTML::escape(col);
     let instances: Option<&Vec<Option<String>>> = row.entries.get(col);

-    let class = HTML::from(if instances.is_none() { "" } else { "yes" });
+    let is_empty = match instances {
+        None => true,
+        Some(is) => is.iter().all(|ins| match ins {
+            None => false,
+            Some(content) => content == "×",
+        }),
+    };
+    let class = HTML::from(if is_empty { "" } else { r#" class="yes""# });

     let contents = match instances {
         None => HTML::from(""),
         Some(is) => render_instances(is),
     };
     row.entries.remove(col);
     HTML(format!(
     let contents = match instances {
         None => HTML::from(""),
         Some(is) => render_instances(is),
     };
     row.entries.remove(col);
     HTML(format!(

-        r#"<td class="{class}" onmouseover="h2('{row_label}','{col_label}')" onmouseout="ch2('{row_label}','{col_label}')">{contents}</td>"#
+        r#"<td{class} onmouseover="h2('{row_label}','{col_label}')" onmouseout="ch2('{row_label}','{col_label}')">{contents}</td>"#

     ))
 }
 
 fn render_leftover(notcol: &str, instances: &[Option<String>]) -> HTML {
     let label = HTML::escape(notcol);
     ))
 }
 
 fn render_leftover(notcol: &str, instances: &[Option<String>]) -> HTML {
     let label = HTML::escape(notcol);

-    let rest = render_instances(instances);
-    if rest == HTML::from("") {
+    if instances.len() == 1 && instances[0].is_none() {

         HTML(format!("{label}"))
     } else {
         HTML(format!("{label}"))
     } else {

+        let rest = render_instances(instances);

         HTML(format!("{label}: {rest}"))
     }
 }
 
 fn render_all_leftovers(config: &Config, row: &Row) -> HTML {
         HTML(format!("{label}: {rest}"))
     }
 }
 
 fn render_all_leftovers(config: &Config, row: &Row) -> HTML {

-    let mut order: Vec<_> = row.entries.keys().collect();
+    let mut order: Vec<_> = row
+        .entries
+        .keys()
+        .filter(|&col| !config.hidden_columns.contains(col))
+        .collect();

     order.sort_unstable();
     HTML(
         order
     order.sort_unstable();
     HTML(
         order


@@ -330,12 +369,14 @@ fn render_row(config: &Config, columns: &[String], rowlike: &mut Rowlike) -> HTM
                 .static_columns
                 .iter()
                 .map(|ocol| match ocol {
                 .static_columns
                 .iter()
                 .map(|ocol| match ocol {

+                    Some(col) if config.hidden_columns.contains(col) => HTML::from(""),

                     Some(col) => render_cell(col, row),
                     None => HTML::from(r#"<td class="spacer_col"></td>"#),
                 })
                 .collect::<HTML>();
             let dynamic_cells = columns
                 .iter()
                     Some(col) => render_cell(col, row),
                     None => HTML::from(r#"<td class="spacer_col"></td>"#),
                 })
                 .collect::<HTML>();
             let dynamic_cells = columns
                 .iter()

+                .filter(|&col| !config.hidden_columns.contains(col))

                 .map(|col| render_cell(col, row))
                 .collect::<HTML>();
             let leftovers = render_all_leftovers(config, row);
                 .map(|col| render_cell(col, row))
                 .collect::<HTML>();
             let leftovers = render_all_leftovers(config, row);


@@ -346,27 +387,40 @@ fn render_row(config: &Config, columns: &[String], rowlike: &mut Rowlike) -> HTM
     }
 }
 
     }
 }
 

-fn render_column_headers(config: &Config, columns: &[String]) -> HTML {
+fn column_header_labels<'a>(
+    config: &'a Config,
+    columns: &'a [String],
+) -> impl Iterator<Item = Option<&'a String>> {

     let static_columns = config.static_columns.iter().map(|oc| oc.as_ref());
     let dynamic_columns = columns.iter().map(Some);
     let static_columns = config.static_columns.iter().map(|oc| oc.as_ref());
     let dynamic_columns = columns.iter().map(Some);

+    static_columns
+        .chain(dynamic_columns)
+        .filter(|ocol| ocol.map_or(true, |col| !config.hidden_columns.contains(col)))
+        .map(|ocol| {
+            ocol.map(|col| match config.substitute_labels.get(col) {
+                None => col,
+                Some(substitute) => substitute,
+            })
+        })
+}
+
+fn render_column_headers(config: &Config, columns: &[String]) -> HTML {

     HTML(
         String::from(r#"<tr class="key"><th></th>"#)
     HTML(
         String::from(r#"<tr class="key"><th></th>"#)

-            + &static_columns
-                .chain(dynamic_columns)
-                .fold(String::new(), |mut acc, ocol| {
-                    match ocol {
-                        Some(col) => {
-                            let col_header = HTML::escape(col);
-                            write!(
-                                &mut acc,
-                                r#"<th id="{col_header}"><div><div>{col_header}</div></div></th>"#
-                            )
-                        }
-                        None => write!(&mut acc, r#"<th class="col_spacer"></th>"#),
+            + &column_header_labels(config, columns).fold(String::new(), |mut acc, ocol| {
+                match ocol {
+                    Some(col) => {
+                        let col_header = HTML::escape(col);
+                        write!(
+                            &mut acc,
+                            r#"<th id="{col_header}"><div><div>{col_header}</div></div></th>"#
+                        )

                     }
                     }

-                    .unwrap();
-                    acc
-                })
+                    None => write!(&mut acc, r#"<th class="col_spacer"></th>"#),
+                }
+                .unwrap();
+                acc
+            })

             + "</tr>\n",
     )
 }
             + "</tr>\n",
     )
 }


@@ -422,6 +476,21 @@ mod tests {
         );
     }
 
         );
     }
 

+    #[test]
+    fn test_tally_marks() {
+        assert_eq!(tally_marks(1), "𝍷");
+        assert_eq!(tally_marks(2), "𝍷𝍷");
+        assert_eq!(tally_marks(3), "𝍷𝍷𝍷");
+        assert_eq!(tally_marks(4), "𝍷𝍷𝍷𝍷");
+        assert_eq!(tally_marks(5), "𝍸");
+        assert_eq!(tally_marks(6), "𝍸𝍷");
+        assert_eq!(tally_marks(7), "𝍸𝍷𝍷");
+        assert_eq!(tally_marks(8), "𝍸𝍷𝍷𝍷");
+        assert_eq!(tally_marks(9), "𝍸𝍷𝍷𝍷𝍷");
+        assert_eq!(tally_marks(10), "𝍸𝍸");
+        assert_eq!(tally_marks(11), "𝍸𝍸𝍷");
+    }
+

     fn read_rows(input: impl std::io::Read) -> Result<Vec<Rowlike>, std::io::Error> {
         read_input(input).map(|(rows, _)| rows)
     }
     fn read_rows(input: impl std::io::Read) -> Result<Vec<Rowlike>, std::io::Error> {
         read_input(input).map(|(rows, _)| rows)
     }


@@ -543,6 +612,12 @@ mod tests {
             read_config(&b"!col foo"[..]).unwrap().static_columns,
             vec![Some("foo".to_owned())]
         );
             read_config(&b"!col foo"[..]).unwrap().static_columns,
             vec![Some("foo".to_owned())]
         );

+        assert_eq!(
+            read_config(&b"!label foo:bar"[..])
+                .unwrap()
+                .substitute_labels["foo"],
+            "bar"
+        );

 
         let bad_command = read_config(&b"!no such command"[..]);
         assert!(bad_command.is_err());
 
         let bad_command = read_config(&b"!no such command"[..]);
         assert!(bad_command.is_err());


@@ -551,6 +626,10 @@ mod tests {
         let bad_num = read_config(&b"!col_threshold foo"[..]);
         assert!(bad_num.is_err());
         assert!(format!("{bad_num:?}").contains("line 1: col_threshold must be numeric"));
         let bad_num = read_config(&b"!col_threshold foo"[..]);
         assert!(bad_num.is_err());
         assert!(format!("{bad_num:?}").contains("line 1: col_threshold must be numeric"));

+
+        let bad_sub = read_config(&b"!label foo"[..]);
+        assert!(bad_sub.is_err());
+        assert!(format!("{bad_sub:?}").contains("line 1: Annotation missing ':'"));

     }
 
     #[test]
     }
 
     #[test]


@@ -575,6 +654,38 @@ mod tests {
         );
     }
 
         );
     }
 

+    #[test]
+    fn test_column_header_labels() {
+        let mut cfg = Config::default();
+
+        assert!(column_header_labels(&cfg, &["foo".to_owned()]).eq([Some(&"foo".to_owned())]));
+
+        cfg.static_columns.push(Some("bar".to_owned()));
+        assert!(column_header_labels(&cfg, &["foo".to_owned()])
+            .eq([Some(&"bar".to_owned()), Some(&"foo".to_owned())]));
+
+        cfg.static_columns.push(None);
+        assert!(column_header_labels(&cfg, &["foo".to_owned()]).eq([
+            Some(&"bar".to_owned()),
+            None,
+            Some(&"foo".to_owned())
+        ]));
+
+        cfg.substitute_labels
+            .insert("foo".to_owned(), "foo (bits)".to_owned());
+        assert!(column_header_labels(&cfg, &["foo".to_owned()]).eq([
+            Some(&"bar".to_owned()),
+            None,
+            Some(&"foo (bits)".to_owned())
+        ]));
+
+        cfg.hidden_columns.insert("foo".to_owned());
+        assert!(column_header_labels(&cfg, &["foo".to_owned()]).eq([Some(&"bar".to_owned()), None]));
+
+        cfg.hidden_columns.insert("bar".to_owned());
+        assert!(column_header_labels(&cfg, &["foo".to_owned()]).eq([None]));
+    }
+

     #[test]
     fn test_render_cell() {
         assert_eq!(
     #[test]
     fn test_render_cell() {
         assert_eq!(


@@ -586,7 +697,7 @@ mod tests {
                 }
             ),
             HTML::from(
                 }
             ),
             HTML::from(

-                r#"<td class="" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td>"#
+                r#"<td onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td>"#

             )
         );
         assert_eq!(
             )
         );
         assert_eq!(


@@ -598,7 +709,7 @@ mod tests {
                 }
             ),
             HTML::from(
                 }
             ),
             HTML::from(

-                r#"<td class="" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td>"#
+                r#"<td onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td>"#

             )
         );
         assert_eq!(
             )
         );
         assert_eq!(


@@ -610,7 +721,7 @@ mod tests {
                 }
             ),
             HTML::from(
                 }
             ),
             HTML::from(

-                r#"<td class="yes" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td>"#
+                r#"<td class="yes" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')">𝍷</td>"#

             )
         );
         assert_eq!(
             )
         );
         assert_eq!(


@@ -622,7 +733,7 @@ mod tests {
                 }
             ),
             HTML::from(
                 }
             ),
             HTML::from(

-                r#"<td class="yes" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')">2</td>"#
+                r#"<td class="yes" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')">𝍷𝍷</td>"#

             )
         );
         assert_eq!(
             )
         );
         assert_eq!(


@@ -649,7 +760,19 @@ mod tests {
                 }
             ),
             HTML::from(
                 }
             ),
             HTML::from(

-                r#"<td class="yes" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')">5 ✓</td>"#
+                r#"<td class="yes" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')">5 𝍷</td>"#
+            )
+        );
+        assert_eq!(
+            render_cell(
+                "foo",
+                &mut Row {
+                    label: "nope".to_owned(),
+                    entries: HashMap::from([("foo".to_owned(), vec![Some("×".to_owned())])]),
+                }
+            ),
+            HTML::from(
+                r#"<td onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')">×</td>"#

             )
         );
         assert_eq!(
             )
         );
         assert_eq!(


@@ -673,7 +796,7 @@ mod tests {
                 }
             ),
             HTML::from(
                 }
             ),
             HTML::from(

-                r#"<td class="yes" onmouseover="h2('bob&#39;s','foo')" onmouseout="ch2('bob&#39;s','foo')"></td>"#
+                r#"<td class="yes" onmouseover="h2('bob&#39;s','foo')" onmouseout="ch2('bob&#39;s','foo')">𝍷</td>"#

             )
         );
         let mut r = Row {
             )
         );
         let mut r = Row {


@@ -728,7 +851,22 @@ mod tests {
                     ]),
                 }
             ),
                     ]),
                 }
             ),

-            HTML::from("bar: 2, foo")
+            HTML::from("bar: 𝍷𝍷, foo")
+        );
+        assert_eq!(
+            render_all_leftovers(
+                &Config {
+                    column_threshold: 2,
+                    static_columns: vec![],
+                    hidden_columns: HashSet::from(["private".to_owned()]),
+                    substitute_labels: HashMap::new(),
+                },
+                &Row {
+                    label: "nope".to_owned(),
+                    entries: HashMap::from([("private".to_owned(), vec![None]),]),
+                }
+            ),
+            HTML::from("")

         );
     }
 
         );
     }
 


@@ -744,7 +882,7 @@ mod tests {
                 })
             ),
             HTML::from(
                 })
             ),
             HTML::from(

-                r#"<tr><th id="nope">nope</th><td class="" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td><td class="leftover" onmouseover="highlight('nope')" onmouseout="clear_highlight('nope')">bar</td></tr>
+                r#"<tr><th id="nope">nope</th><td onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td><td class="leftover" onmouseover="highlight('nope')" onmouseout="clear_highlight('nope')">bar</td></tr>

 "#
             )
         );
 "#
             )
         );


@@ -753,6 +891,8 @@ mod tests {
                 &Config {
                     column_threshold: 0,
                     static_columns: vec![Some("foo".to_owned()), Some("bar".to_owned())],
                 &Config {
                     column_threshold: 0,
                     static_columns: vec![Some("foo".to_owned()), Some("bar".to_owned())],

+                    hidden_columns: HashSet::new(),
+                    substitute_labels: HashMap::new(),

                 },
                 &["baz".to_owned()],
                 &mut Rowlike::Row(Row {
                 },
                 &["baz".to_owned()],
                 &mut Rowlike::Row(Row {


@@ -774,6 +914,8 @@ mod tests {
                 &Config {
                     column_threshold: 0,
                     static_columns: vec![Some("foo".to_owned()), None, Some("bar".to_owned())],
                 &Config {
                     column_threshold: 0,
                     static_columns: vec![Some("foo".to_owned()), None, Some("bar".to_owned())],

+                    hidden_columns: HashSet::new(),
+                    substitute_labels: HashMap::new(),

                 },
                 &[],
                 &mut Rowlike::Row(Row {
                 },
                 &[],
                 &mut Rowlike::Row(Row {


@@ -786,6 +928,44 @@ mod tests {
             ),
             HTML::from(
                 r#"<tr><th id="nope">nope</th><td class="yes" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')">f</td><td class="spacer_col"></td><td class="yes" onmouseover="h2('nope','bar')" onmouseout="ch2('nope','bar')">r</td><td class="leftover" onmouseover="highlight('nope')" onmouseout="clear_highlight('nope')"></td></tr>
             ),
             HTML::from(
                 r#"<tr><th id="nope">nope</th><td class="yes" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')">f</td><td class="spacer_col"></td><td class="yes" onmouseover="h2('nope','bar')" onmouseout="ch2('nope','bar')">r</td><td class="leftover" onmouseover="highlight('nope')" onmouseout="clear_highlight('nope')"></td></tr>

+"#
+            )
+        );
+        assert_eq!(
+            render_row(
+                &Config {
+                    column_threshold: 0,
+                    static_columns: vec![],
+                    hidden_columns: HashSet::from(["foo".to_owned()]),
+                    substitute_labels: HashMap::new(),
+                },
+                &[],
+                &mut Rowlike::Row(Row {
+                    label: "nope".to_owned(),
+                    entries: HashMap::from([("foo".to_owned(), vec![Some("f".to_owned())]),]),
+                })
+            ),
+            HTML::from(
+                r#"<tr><th id="nope">nope</th><td class="leftover" onmouseover="highlight('nope')" onmouseout="clear_highlight('nope')"></td></tr>
+"#
+            )
+        );
+        assert_eq!(
+            render_row(
+                &Config {
+                    column_threshold: 0,
+                    static_columns: vec![Some("foo".to_owned())],
+                    hidden_columns: HashSet::from(["foo".to_owned()]),
+                    substitute_labels: HashMap::new(),
+                },
+                &[],
+                &mut Rowlike::Row(Row {
+                    label: "nope".to_owned(),
+                    entries: HashMap::from([("foo".to_owned(), vec![Some("f".to_owned())]),]),
+                })
+            ),
+            HTML::from(
+                r#"<tr><th id="nope">nope</th><td class="leftover" onmouseover="highlight('nope')" onmouseout="clear_highlight('nope')"></td></tr>

 "#
             )
         );
 "#
             )
         );