]> git.scottworley.com Git - tablify/blobdiff - src/lib.rs
projects / tablify / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | inline | side by side
Plumb config into render_cell()
[tablify] / src / lib.rs
diff --git a/src/lib.rs b/src/lib.rs
index 859b3c19157d11b1e003165bbc7a72249641fc62..70dfb5286fc628819c9315618d655040b67221e1 100644 (file)
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -311,7 +311,7 @@ fn render_instances(instances: &[Option<String>]) -> HTML {
     )
 }
 
-fn render_cell(col: &str, row: &mut Row) -> HTML {
+fn render_cell(config: &Config, col: &str, row: &mut Row) -> HTML {
     let row_label = HTML::escape(row.label.as_ref());
     let col_label = HTML::escape(col);
     let instances: Option<&Vec<Option<String>>> = row.entries.get(col);
@@ -322,14 +322,14 @@ fn render_cell(col: &str, row: &mut Row) -> HTML {
             Some(content) => content == "×",
         }),
     };
-    let class = HTML::from(if is_empty { "" } else { "yes" });
+    let class = HTML::from(if is_empty { "" } else { r#" class="yes""# });
     let contents = match instances {
         None => HTML::from(""),
         Some(is) => render_instances(is),
     };
     row.entries.remove(col);
     HTML(format!(
-        r#"<td class="{class}" onmouseover="h2('{row_label}','{col_label}')" onmouseout="ch2('{row_label}','{col_label}')">{contents}</td>"#
+        r#"<td{class} onmouseover="h2('{row_label}','{col_label}')" onmouseout="ch2('{row_label}','{col_label}')">{contents}</td>"#
     ))
 }
 
@@ -370,14 +370,14 @@ fn render_row(config: &Config, columns: &[String], rowlike: &mut Rowlike) -> HTM
                 .iter()
                 .map(|ocol| match ocol {
                     Some(col) if config.hidden_columns.contains(col) => HTML::from(""),
-                    Some(col) => render_cell(col, row),
+                    Some(col) => render_cell(config, col, row),
                     None => HTML::from(r#"<td class="spacer_col"></td>"#),
                 })
                 .collect::<HTML>();
             let dynamic_cells = columns
                 .iter()
                 .filter(|&col| !config.hidden_columns.contains(col))
-                .map(|col| render_cell(col, row))
+                .map(|col| render_cell(config, col, row))
                 .collect::<HTML>();
             let leftovers = render_all_leftovers(config, row);
             HTML(format!(
@@ -690,6 +690,7 @@ mod tests {
     fn test_render_cell() {
         assert_eq!(
             render_cell(
+                &Config::default(),
                 "foo",
                 &mut Row {
                     label: "nope".to_owned(),
@@ -697,11 +698,12 @@ mod tests {
                 }
             ),
             HTML::from(
-                r#"<td class="" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td>"#
+                r#"<td onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td>"#
             )
         );
         assert_eq!(
             render_cell(
+                &Config::default(),
                 "foo",
                 &mut Row {
                     label: "nope".to_owned(),
@@ -709,11 +711,12 @@ mod tests {
                 }
             ),
             HTML::from(
-                r#"<td class="" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td>"#
+                r#"<td onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td>"#
             )
         );
         assert_eq!(
             render_cell(
+                &Config::default(),
                 "foo",
                 &mut Row {
                     label: "nope".to_owned(),
@@ -726,6 +729,7 @@ mod tests {
         );
         assert_eq!(
             render_cell(
+                &Config::default(),
                 "foo",
                 &mut Row {
                     label: "nope".to_owned(),
@@ -738,6 +742,7 @@ mod tests {
         );
         assert_eq!(
             render_cell(
+                &Config::default(),
                 "foo",
                 &mut Row {
                     label: "nope".to_owned(),
@@ -753,6 +758,7 @@ mod tests {
         );
         assert_eq!(
             render_cell(
+                &Config::default(),
                 "foo",
                 &mut Row {
                     label: "nope".to_owned(),
@@ -765,6 +771,7 @@ mod tests {
         );
         assert_eq!(
             render_cell(
+                &Config::default(),
                 "foo",
                 &mut Row {
                     label: "nope".to_owned(),
@@ -772,11 +779,12 @@ mod tests {
                 }
             ),
             HTML::from(
-                r#"<td class="" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')">×</td>"#
+                r#"<td onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')">×</td>"#
             )
         );
         assert_eq!(
             render_cell(
+                &Config::default(),
                 "heart",
                 &mut Row {
                     label: "nope".to_owned(),
@@ -789,6 +797,7 @@ mod tests {
         );
         assert_eq!(
             render_cell(
+                &Config::default(),
                 "foo",
                 &mut Row {
                     label: "bob's".to_owned(),
@@ -807,11 +816,11 @@ mod tests {
             ]),
         };
         assert_eq!(r.entries.len(), 2);
-        render_cell("foo", &mut r);
+        render_cell(&Config::default(), "foo", &mut r);
         assert_eq!(r.entries.len(), 1);
-        render_cell("bar", &mut r);
+        render_cell(&Config::default(), "bar", &mut r);
         assert_eq!(r.entries.len(), 1);
-        render_cell("baz", &mut r);
+        render_cell(&Config::default(), "baz", &mut r);
         assert_eq!(r.entries.len(), 0);
     }
 
@@ -882,7 +891,7 @@ mod tests {
                 })
             ),
             HTML::from(
-                r#"<tr><th id="nope">nope</th><td class="" onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td><td class="leftover" onmouseover="highlight('nope')" onmouseout="clear_highlight('nope')">bar</td></tr>
+                r#"<tr><th id="nope">nope</th><td onmouseover="h2('nope','foo')" onmouseout="ch2('nope','foo')"></td><td class="leftover" onmouseover="highlight('nope')" onmouseout="clear_highlight('nope')">bar</td></tr>
 "#
             )
         );
Summarize a text log as an HTML table