Line numbers in error messages

[tablify] / src / lib.rs

diff --git a/src/lib.rs b/src/lib.rs
index b583c3eefb0b3e3f1ea74f0aae24556b711865a1..56a2b6ddec94a404a23d582bbf3b16fcc06bb5bc 100644 (file)
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -10,31 +10,43 @@ struct RowInput {
 }
 
 struct Reader<Input: Iterator<Item = Result<String, std::io::Error>>> {
-    input: Input,
+    input: std::iter::Enumerate<Input>,
     row: Option<RowInput>,
 }
 impl<Input: Iterator<Item = Result<String, std::io::Error>>> Reader<Input> {
     #[cfg(test)]
     fn new(input: Input) -> Self {
-        Self { input, row: None }
+        Self {
+            input: input.enumerate(),
+            row: None,
+        }
     }
 }
 impl<Input: Iterator<Item = Result<String, std::io::Error>>> Iterator for Reader<Input> {
     type Item = Result<RowInput, std::io::Error>;
     fn next(&mut self) -> Option<Self::Item> {
         loop {
-            match self.input.next() {
+            match self
+                .input
+                .next()
+                .map(|(n, r)| (n, r.map(|line| String::from(line.trim_end()))))
+            {
                 None => return Ok(std::mem::take(&mut self.row)).transpose(),
-                Some(Err(e)) => return Some(Err(e)),
-                Some(Ok(line)) if line.is_empty() && self.row.is_some() => {
+                Some((_, Err(e))) => return Some(Err(e)),
+                Some((_, Ok(line))) if line.is_empty() && self.row.is_some() => {
                     return Ok(std::mem::take(&mut self.row)).transpose()
                 }
-                Some(Ok(line)) if line.is_empty() => {}
-                Some(Ok(line)) if line.starts_with(' ') => match &mut self.row {
-                    None => return Some(Err(std::io::Error::other("Entry with no header"))),
+                Some((_, Ok(line))) if line.is_empty() => {}
+                Some((n, Ok(line))) if line.starts_with(' ') => match &mut self.row {
+                    None => {
+                        return Some(Err(std::io::Error::other(format!(
+                            "{}: Entry with no header",
+                            n + 1
+                        ))))
+                    }
                     Some(ref mut row) => row.entries.push(String::from(line.trim())),
                 },
-                Some(Ok(line)) => {
+                Some((_, Ok(line))) => {
                     let prev = std::mem::take(&mut self.row);
                     self.row = Some(RowInput {
                         label: line,
@@ -122,13 +134,37 @@ mod tests {
                 }
             ]
         );
+        assert_eq!(
+            read_rows(&b"foo\n \nbar\n"[..])
+                .flatten()
+                .collect::<Vec<_>>(),
+            vec![
+                RowInput {
+                    label: String::from("foo"),
+                    entries: vec![]
+                },
+                RowInput {
+                    label: String::from("bar"),
+                    entries: vec![]
+                }
+            ]
+        );
+        assert_eq!(
+            read_rows(&b"foo  \n bar  \n"[..])
+                .flatten()
+                .collect::<Vec<_>>(),
+            vec![RowInput {
+                label: String::from("foo"),
+                entries: vec![String::from("bar")]
+            }]
+        );
 
         let bad = read_rows(&b" foo"[..]).next().unwrap();
         assert!(bad.is_err());
-        assert!(format!("{bad:?}").contains("Entry with no header"));
+        assert!(format!("{bad:?}").contains("1: Entry with no header"));
 
         let bad2 = read_rows(&b"foo\n\n bar"[..]).nth(1).unwrap();
         assert!(bad2.is_err());
-        assert!(format!("{bad2:?}").contains("Entry with no header"));
+        assert!(format!("{bad2:?}").contains("3: Entry with no header"));
     }
 }