Escape character names

This is slow. :(

diff --git a/glowfic.py b/glowfic.py
index 573050872d3d3d3ef6e5647c02dcb4f238e65e21..a700995bf93f6950d2b63a403ee57c4f757c0d9a 100644 (file)
--- a/glowfic.py
+++ b/glowfic.py
@@ -39,9 +39,9 @@ def flatURL(url: str) -> str:
 @dataclass(frozen=True)
 class Chunk:
     icon: str | None
-    character: str | None
-    screen_name: str | None
-    author: str | None
+    character: Tag | None
+    screen_name: Tag | None
+    author: Tag | None
     content: Tag
 
 # We avoid the name "post" because the Glowfic community uses the term
@@ -83,19 +83,18 @@ def makeChunk(chunk_dom: Tag, image_store: ImageStore) -> Chunk:
         assert isinstance(icon_img, Tag)
         return image_store.get_image(icon_img.attrs['src'])
 
-    def getTextByClass(css_class: str) -> str | None:
-        div = chunk_dom.find_next('div', class_=css_class)
-        if div is None:
-            return None
-        return div.text.strip()
+    def getByClass(css_class: str) -> Tag | None:
+        tag = chunk_dom.find_next('div', class_=css_class)
+        assert tag is None or isinstance(tag, Tag)
+        return tag
 
     content = chunk_dom.find_next('div', class_='post-content')
     assert isinstance(content, Tag)
 
     return Chunk(getIcon(),
-                 getTextByClass('post-character'),
-                 getTextByClass('post-screenname'),
-                 getTextByClass('post-author'),
+                 getByClass('post-character'),
+                 getByClass('post-screenname'),
+                 getByClass('post-author'),
                  content)
 
 
@@ -127,12 +126,11 @@ class BelowIconLayout(Layout):
         self._image_size = image_size
 
     def renderChunk(self, chunk: Chunk) -> bytes:
-        meta = [
-            renderIcon(chunk.icon, self._image_size),
-            chunk.character,
-            chunk.screen_name,
-            chunk.author,
-        ]
+        icon = renderIcon(chunk.icon, self._image_size)
+        meta = [icon.encode('UTF-8')] if icon else []
+        meta += [self._texifier.texify(x)
+                 for x in [chunk.character, chunk.screen_name, chunk.author]
+                 if x is not None]
 
         return b'''\\wrapstuffclear
 \\begin{wrapstuff}[l]
@@ -156,7 +154,7 @@ class BelowIconLayout(Layout):
 
 \\noindent %s
 ''' % (
-            b'\\\\*'.join(x.encode('UTF-8') for x in meta if x is not None),
+            b'\\\\*'.join(meta),
             self._texifier.texify(chunk.content))
 
 
@@ -191,5 +189,5 @@ class BesideIconLayout(Layout):
 
 ''' % (
             icon.encode('UTF-8') if icon else b'',
-            b'\\\\*'.join(x.encode('UTF-8') for x in meta if x is not None),
+            b'\\\\*'.join(self._texifier.texify(x) for x in meta if x is not None),
             self._texifier.texify(chunk.content))

diff --git a/glowfic_test.py b/glowfic_test.py
index d3a6d563f8930150eb32296ceb1973afb96d3af8..9b802c180cf3463e659f892948b0c9a64d4f936e 100644 (file)
--- a/glowfic_test.py
+++ b/glowfic_test.py
@@ -57,9 +57,13 @@ class TestMakeChunk(unittest.TestCase):
             c.icon,
             'stored:https://d1anwqy6ci9o1i.cloudfront.net/' +
             'users%2F366%2Ficons%2Fxqmypqvflgdy28aorw9ml_shock.png')
-        self.assertEqual(c.character, 'Keltham')
-        self.assertEqual(c.screen_name, 'lawful chaotic')
-        self.assertEqual(c.author, 'Iarwain')
+        assert c.character
+        assert c.screen_name
+        assert c.author
+        self.assertEqual(list(c.character.stripped_strings), ['Keltham'])
+        self.assertEqual(
+            list(c.screen_name.stripped_strings), ['lawful chaotic'])
+        self.assertEqual(list(c.author.stripped_strings), ['Iarwain'])
         self.assertEqual(str(c.content),
                          '<div class="post-content"><p></p></div>')