summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
54c1918)
Tags broke task.textContent being an easy way to get the task
description, which editTask was using. This restores neatness & fixes a
bug in which tag names were slurped into the edit-task buffer.
const Model = {
addTask: function (timestamp: string, description: string): Element {
const task = document.createElement("div");
const Model = {
addTask: function (timestamp: string, description: string): Element {
const task = document.createElement("div");
- task.appendChild(document.createTextNode(description));
+ const desc = document.createElement("span");
+ desc.textContent = description;
+ desc.classList.add("desc");
+ task.appendChild(desc);
task.classList.add("task");
task.setAttribute("tabindex", "0");
task.setAttribute("data-created", timestamp);
task.classList.add("task");
task.setAttribute("tabindex", "0");
task.setAttribute("data-created", timestamp);
target.setAttribute("data-description", newDescription);
}
} else {
target.setAttribute("data-description", newDescription);
}
} else {
- target.textContent = newDescription;
+ target.getElementsByClassName("desc")[0].textContent = newDescription;
const task = document.activeElement;
if (!task) return;
const input = document.createElement("input");
const task = document.activeElement;
if (!task) return;
const input = document.createElement("input");
- const oldDescription = task.textContent!;
+ const desc = task.getElementsByClassName("desc")[0];
+ const oldDescription = desc.textContent!;
task.setAttribute("data-description", oldDescription);
input.value = oldDescription;
input.addEventListener("blur", this.completeEdit, { once: true });
task.setAttribute("data-description", oldDescription);
input.value = oldDescription;
input.addEventListener("blur", this.completeEdit, { once: true });
task.insertBefore(input, task.firstChild);
input.focus();
event.preventDefault();
task.insertBefore(input, task.firstChild);
input.focus();
event.preventDefault();
completeEdit: function (event: Event, resolution: CommitOrAbort = CommitOrAbort.Commit) {
const input = event.target as HTMLInputElement;
const task = input.parentElement!;
completeEdit: function (event: Event, resolution: CommitOrAbort = CommitOrAbort.Commit) {
const input = event.target as HTMLInputElement;
const task = input.parentElement!;
+ const desc = task.getElementsByClassName("desc")[0];
const oldDescription = task.getAttribute("data-description")!;
const newDescription = input.value;
input.removeEventListener("blur", this.completeEdit);
const oldDescription = task.getAttribute("data-description")!;
const newDescription = input.value;
input.removeEventListener("blur", this.completeEdit);
task.removeAttribute("data-description");
task.focus();
if (newDescription === oldDescription || resolution === CommitOrAbort.Abort) {
task.removeAttribute("data-description");
task.focus();
if (newDescription === oldDescription || resolution === CommitOrAbort.Abort) {
- task.textContent = oldDescription;
+ desc.textContent = oldDescription;
} else {
ui.edit(task.getAttribute("data-created")!, newDescription, oldDescription);
}
} else {
ui.edit(task.getAttribute("data-created")!, newDescription, oldDescription);
}