Replace setUntaggedView() with a TagFilter

[vopamoi] / vopamoi.ts

diff --git a/vopamoi.ts b/vopamoi.ts
index c72884eb7d459d86d90536645d5c84374e4d5058..f37ce2e787559c6b4ce7e6db72b6c68f115f8a87 100644 (file)
--- a/vopamoi.ts
+++ b/vopamoi.ts
@@ -310,6 +310,11 @@ enum CommitOrAbort {
   Abort,
 }
 
+interface TagFilter {
+  description: string;
+  include: (task: Element) => boolean;
+}
+
 function BrowserUI() {
   const viewColors: { [key: string]: string } = {
     all: "Gold",
@@ -320,7 +325,7 @@ function BrowserUI() {
     todo: "White",
     waiting: "MediumOrchid",
   };
-  var currentTagFilter: string | null = null;
+  var currentTagFilter: TagFilter | null = null;
   var currentViewState = "todo";
   var taskFocusedBeforeJumpingToInput: HTMLElement | null = null;
   var lastTagNameEntered = "";
@@ -611,20 +616,14 @@ function BrowserUI() {
       return ui.setState(createTimestamp, newState, oldState);
     },
 
-    setTagView: function (tag: string | null = null) {
-      if (tag === null) {
-        const target = this.currentTag();
-        if (!target) return;
-        tag = target.textContent!;
-      }
-
+    setTagFilter: function (filter: TagFilter) {
       if (currentTagFilter !== null) {
         this.resetTagView();
       }
 
       const tasksWithTag = new Map();
       for (const task of document.getElementsByClassName("task")) {
-        if (model.hasTag(task, tag)) {
+        if (filter.include(task)) {
           tasksWithTag.set(task.getElementsByClassName("desc")[0].textContent, [model.getPriority(task), task]);
         }
       }
@@ -643,7 +642,7 @@ function BrowserUI() {
       }
 
       for (const task of Array.from(document.getElementsByClassName("task"))) {
-        if (model.hasTag(task, tag)) {
+        if (filter.include(task)) {
           task.classList.remove("hide");
         } else {
           const superTask = highestPrioritySuperTask(task);
@@ -655,12 +654,21 @@ function BrowserUI() {
         }
       }
 
-      currentTagFilter = tag;
+      currentTagFilter = filter;
       this.setTitle();
     },
 
+    setTagView: function (tag: string | null = null) {
+      if (tag === null) {
+        const target = this.currentTag();
+        if (!target) return;
+        tag = target.textContent!;
+      }
+      this.setTagFilter({description: tag, include: task => !!model.hasTag(task, tag!)});
+    },
+
     setTitle: function () {
-      document.title = "Vopamoi: " + currentViewState + (currentTagFilter ? ": " + currentTagFilter : "");
+      document.title = "Vopamoi: " + currentViewState + (currentTagFilter ? ": " + currentTagFilter.description : "");
     },
 
     setView: function (state: string) {
@@ -681,16 +689,7 @@ function BrowserUI() {
     },
 
     setUntaggedView: function () {
-      if (currentTagFilter !== null) {
-        this.resetTagView();
-      }
-      for (const task of document.getElementsByClassName("task")) {
-        if (task.getElementsByClassName("tag").length === 0) {
-          task.classList.remove("hide");
-        } else {
-          task.classList.add("hide");
-        }
-      }
+      this.setTagFilter({description: "(untagged)", include: task => task.getElementsByClassName("tag").length === 0});
     },
 
     undo: function () {