Don't create duplicate tags; Tagging is idempotent

[vopamoi] / vopamoi.ts

diff --git a/vopamoi.ts b/vopamoi.ts
index 5ac82ef516854c12232026753594d8686fbc0db7..3b2f1638beb180e3e6b294cfa59b23ee2c73fe3d 100644 (file)
--- a/vopamoi.ts
+++ b/vopamoi.ts
@@ -44,6 +44,8 @@ const Model = {
   addTag: function (createTimestamp: string, tagName: string): Element | null {
     const task = this.getTask(createTimestamp);
     if (!task) return null;
+    const existingTag = this.hasTag(task, tagName);
+    if (existingTag) return existingTag;
     const tag = document.createElement("span");
     tag.appendChild(document.createTextNode(tagName));
     tag.classList.add("tag");
@@ -77,6 +79,15 @@ const Model = {
     return target;
   },
 
+  hasTag: function (task: Element, tag: string): Element | null {
+    for (const child of task.children) {
+      if (child.classList.contains("tag") && child.textContent === tag) {
+        return child;
+      }
+    }
+    return null;
+  },
+
   getPriority: function (task: Element): number {
     if (task.hasAttribute("data-priority")) {
       return parseFloat(task.getAttribute("data-priority")!);
@@ -270,7 +281,9 @@ function BrowserUI() {
       input.removeEventListener("blur", this.completeTagEdit);
       task.removeChild(input);
       task.focus();
-      ui.addTag(task.getAttribute("data-created")!, newTagName);
+      if (!Model.hasTag(task, newTagName)) {
+        ui.addTag(task.getAttribute("data-created")!, newTagName);
+      }
     },
 
     firstVisibleTask: function () {