Explicitly remove the completeEdit onblur event listener

[vopamoi] / vopamoi.ts

diff --git a/vopamoi.ts b/vopamoi.ts
index 298e513fde6ff3df3abe46fc3080435ae9a854b8..04c5d414be7a46190e4d5679991b0d1edc4cd38e 100644 (file)
--- a/vopamoi.ts
+++ b/vopamoi.ts
@@ -21,10 +21,35 @@ const Model = {
     task.setAttribute("tabindex", "0");
     task.setAttribute("data-created", timestamp);
     document.getElementById("tasks")!.appendChild(task);
     task.setAttribute("tabindex", "0");
     task.setAttribute("data-created", timestamp);
     document.getElementById("tasks")!.appendChild(task);

-    task.focus();

     return task;
   },
 
     return task;
   },
 

+  edit: function (createTimestamp: string, newDescription: string): Element | null {
+    const target = this.getTask(createTimestamp);
+    if (!target) return null;
+    if (target.hasAttribute("data-description")) {
+      // Oh no: An edit has arrived from a replica while a local edit is in progress.
+      const input = target.children[0] as HTMLInputElement;
+      if (
+        input.value === target.getAttribute("data-description") &&
+        input.selectionStart === 0 &&
+        input.selectionEnd === input.value.length
+      ) {
+        // No local changes have actually been made yet.  Change the contents of the edit box!
+        input.value = newDescription;
+        input.select();
+      } else {
+        // No great options.
+        // Prefer not to interrupt the local user's edit.
+        // The remote edit is mostly lost; this mostly becomes last-write-wins.
+        target.setAttribute("data-description", newDescription);
+      }
+    } else {
+      target.textContent = newDescription;
+    }
+    return target;
+  },
+

   getPriority: function (task: Element): number {
     if (task.hasAttribute("data-priority")) {
       return parseFloat(task.getAttribute("data-priority")!);
   getPriority: function (task: Element): number {
     if (task.hasAttribute("data-priority")) {
       return parseFloat(task.getAttribute("data-priority")!);


@@ -51,12 +76,10 @@ const Model = {
     for (const task of document.getElementsByClassName("task")) {
       if (task !== target && this.getPriority(task) > priority) {
         task.parentElement!.insertBefore(target, task);
     for (const task of document.getElementsByClassName("task")) {
       if (task !== target && this.getPriority(task) > priority) {
         task.parentElement!.insertBefore(target, task);

-        target instanceof HTMLElement && target.focus();

         return target;
       }
     }
     document.getElementById("tasks")!.appendChild(target);
         return target;
       }
     }
     document.getElementById("tasks")!.appendChild(target);

-    target instanceof HTMLElement && target.focus();

     return target;
   },
 
     return target;
   },
 


@@ -79,6 +102,10 @@ function Log(prefix: string = "vp-") {
       if (command == "Create") {
         return Model.addTask(timestamp, data);
       }
       if (command == "Create") {
         return Model.addTask(timestamp, data);
       }

+      if (command == "Edit") {
+        const [createTimestamp, description] = splitN(data, " ", 1);
+        return Model.edit(createTimestamp, description);
+      }

       if (command == "State") {
         const [createTimestamp, state] = splitN(data, " ", 1);
         return Model.setState(timestamp, createTimestamp, state);
       if (command == "State") {
         const [createTimestamp, state] = splitN(data, " ", 1);
         return Model.setState(timestamp, createTimestamp, state);


@@ -120,6 +147,10 @@ const UI = {
     undoLog.push(`State ${now} deleted`);
     return <Element>log.recordAndApply(`${now} Create ${description}`);
   },
     undoLog.push(`State ${now} deleted`);
     return <Element>log.recordAndApply(`${now} Create ${description}`);
   },

+  edit: function (createTimestamp: string, newDescription: string, oldDescription: string) {
+    undoLog.push(`Edit ${createTimestamp} ${oldDescription}`);
+    return log.recordAndApply(`${Date.now()} Edit ${createTimestamp} ${newDescription}`);
+  },

   setPriority: function (createTimestamp: string, newPriority: number, oldPriority: number) {
     undoLog.push(`Priority ${createTimestamp} ${oldPriority}`);
     return log.recordAndApply(`${Date.now()} Priority ${createTimestamp} ${newPriority}`);
   setPriority: function (createTimestamp: string, newPriority: number, oldPriority: number) {
     undoLog.push(`Priority ${createTimestamp} ${oldPriority}`);
     return log.recordAndApply(`${Date.now()} Priority ${createTimestamp} ${newPriority}`);


@@ -140,6 +171,7 @@ const BrowserUI = {
     const input = <HTMLInputElement>document.getElementById("taskName");
     if (input.value) {
       const task = UI.addTask(input.value);
     const input = <HTMLInputElement>document.getElementById("taskName");
     if (input.value) {
       const task = UI.addTask(input.value);

+      if (task && task instanceof HTMLElement) task.focus();

       input.value = "";
       if (event.getModifierState("Control")) {
         this.setPriority(task, null, document.getElementsByClassName("task")[0]);
       input.value = "";
       if (event.getModifierState("Control")) {
         this.setPriority(task, null, document.getElementsByClassName("task")[0]);


@@ -147,6 +179,37 @@ const BrowserUI = {
     }
   },
 
     }
   },
 

+  beginEdit: function (event: Event) {
+    const task = document.activeElement;
+    if (!task) return;
+    const input = document.createElement("input");
+    const oldDescription = task.textContent!;
+    task.setAttribute("data-description", oldDescription);
+    input.value = oldDescription;
+    input.addEventListener("blur", BrowserUI.completeEdit, { once: true });
+    task.textContent = "";
+    task.appendChild(input);
+    input.focus();
+    input.select();
+    event.preventDefault();
+  },
+
+  completeEdit: function (event: Event) {
+    const input = event.target as HTMLInputElement;
+    const task = input.parentElement!;
+    const oldDescription = task.getAttribute("data-description")!;
+    const newDescription = input.value;
+    input.removeEventListener("blur", BrowserUI.completeEdit);
+    task.removeChild(task.children[0]);
+    task.removeAttribute("data-description");
+    task.focus();
+    if (newDescription === oldDescription) {
+      task.textContent = oldDescription;
+    } else {
+      UI.edit(task.getAttribute("data-created")!, newDescription, oldDescription);
+    }
+  },
+

   firstVisibleTask: function () {
     for (const task of document.getElementsByClassName("task")) {
       if (task instanceof HTMLElement && task.style.display !== "none") {
   firstVisibleTask: function () {
     for (const task of document.getElementsByClassName("task")) {
       if (task instanceof HTMLElement && task.style.display !== "none") {


@@ -212,14 +275,17 @@ const BrowserUI = {
     const newPriorityRounded = Math.round(newPriority);
     const okToRound = aPriority < newPriorityRounded && newPriorityRounded < bPriority;
     UI.setPriority(task.getAttribute("data-created")!, okToRound ? newPriorityRounded : newPriority, Model.getPriority(task));
     const newPriorityRounded = Math.round(newPriority);
     const okToRound = aPriority < newPriorityRounded && newPriorityRounded < bPriority;
     UI.setPriority(task.getAttribute("data-created")!, okToRound ? newPriorityRounded : newPriority, Model.getPriority(task));

+    task instanceof HTMLElement && task.focus();

   },
 
   },
 

-  setState: function (state: string) {
+  setState: function (newState: string) {

     const task = document.activeElement;
     if (!task) return;
     const task = document.activeElement;
     if (!task) return;

+    const oldState = Model.getState(task);
+    if (newState === oldState) return;

     const createTimestamp = task.getAttribute("data-created")!;
     this.moveCursor(1) || this.moveCursor(-1);
     const createTimestamp = task.getAttribute("data-created")!;
     this.moveCursor(1) || this.moveCursor(-1);

-    return UI.setState(createTimestamp, state, Model.getState(task));
+    return UI.setState(createTimestamp, newState, oldState);

   },
 
   undo: function () {
   },
 
   undo: function () {


@@ -230,7 +296,11 @@ const BrowserUI = {
 
 function handleKey(event: any) {
   if (event.target.tagName === "INPUT") {
 
 function handleKey(event: any) {
   if (event.target.tagName === "INPUT") {

-    if (event.key == "Enter") return BrowserUI.addTask(event);
+    if (event.target.id === "taskName") {
+      if (event.key == "Enter") return BrowserUI.addTask(event);
+    } else {
+      if (event.key == "Enter") return BrowserUI.completeEdit(event);
+    }

   } else {
     if (event.key == "j") return BrowserUI.moveCursor(1);
     if (event.key == "k") return BrowserUI.moveCursor(-1);
   } else {
     if (event.key == "j") return BrowserUI.moveCursor(1);
     if (event.key == "k") return BrowserUI.moveCursor(-1);


@@ -241,8 +311,10 @@ function handleKey(event: any) {
     if (event.key == "w") return BrowserUI.setState("waiting");
     if (event.key == "d") return BrowserUI.setState("done");
     if (event.key == "c") return BrowserUI.setState("cancelled");
     if (event.key == "w") return BrowserUI.setState("waiting");
     if (event.key == "d") return BrowserUI.setState("done");
     if (event.key == "c") return BrowserUI.setState("cancelled");

+    if (event.key == "t") return BrowserUI.setState("todo");

     if (event.key == "X") return BrowserUI.setState("deleted");
     if (event.key == "u") return BrowserUI.undo();
     if (event.key == "X") return BrowserUI.setState("deleted");
     if (event.key == "u") return BrowserUI.undo();

+    if (event.key == "e") return BrowserUI.beginEdit(event);

   }
 }
 
   }
 }