Edit should still work when a tag has focus

[vopamoi] / vopamoi.ts

diff --git a/vopamoi.ts b/vopamoi.ts
index 3ccc5625e085fa44e6cde1fb2daef9cc515fd37f..73fc5d90b5c81c0ea246dbcbfd163178abfe0bb3 100644 (file)
--- a/vopamoi.ts
+++ b/vopamoi.ts
@@ -287,8 +287,9 @@ function BrowserUI() {
     },
 
     beginEdit: function (event: Event) {
-      const task = document.activeElement;
+      var task = document.activeElement;
       if (!task) return;
+      if (task.classList.contains("tag")) task = task.parentElement!;
       const input = document.createElement("input");
       const desc = task.getElementsByClassName("desc")[0];
       const oldDescription = desc.textContent!;
@@ -378,6 +379,13 @@ function BrowserUI() {
       return valid_cursor;
     },
 
+    jumpCursor: function (position: number) {
+      const first = this.firstVisibleTask();
+      if (!first) return;
+      const dest = this.visibleTaskAtOffset(first, position - 1);
+      if (dest instanceof HTMLElement) dest.focus();
+    },
+
     makeTopPriority: function (task: Element | null = null) {
       if (!task) task = document.activeElement;
       if (!task) return;
@@ -482,6 +490,7 @@ function BrowserUI() {
 }
 const browserUI = BrowserUI();
 
+const scrollIncrement = 60;
 enum InputState {
   Root,
   S,
@@ -492,6 +501,7 @@ var inputState = InputState.Root;
 var inputCount: number | null = null;
 
 function handleKey(event: any) {
+  if (["Alt", "Control", "Meta", "Shift"].includes(event.key)) return;
   if (event.target.tagName === "INPUT") {
     if (event.target.id === "taskName") {
       if (event.key == "Enter") return browserUI.addTask(event);
@@ -509,24 +519,30 @@ function handleKey(event: any) {
         return (inputCount = (inputCount ?? 0) * 10 + parseInt(event.key));
       }
       try {
-        if (event.key == "j") return browserUI.moveCursor(inputCount ?? 1);
-        if (event.key == "k") return browserUI.moveCursor(-(inputCount ?? 1));
-        if (event.key == "J") return browserUI.moveTask(1);
-        if (event.key == "K") return browserUI.moveTask(-1);
-        if (event.key == "T") return browserUI.makeTopPriority();
-        if (event.key == "n") return browserUI.focusTaskNameInput(event);
-        if (event.key == "c") return browserUI.setState("cancelled");
-        if (event.key == "d") return browserUI.setState("done");
-        if (event.key == "q") return browserUI.setState("todo");
-        if (event.key == "s") return (inputState = InputState.S);
-        if (event.key == "w") return browserUI.setState("waiting");
-        if (event.key == "X") return browserUI.setState("deleted");
-        if (event.key == "x") return browserUI.removeTag();
-        if (event.key == "u") return browserUI.undo();
-        if (event.key == "r") return browserUI.redo();
-        if (event.key == "e") return browserUI.beginEdit(event);
-        if (event.key == "t") return browserUI.beginTagEdit(event);
-        if (event.key == "v") return (inputState = InputState.V);
+        if (event.ctrlKey) {
+          if (event.key == "e") return window.scrollBy(0, (inputCount ?? 1) * scrollIncrement);
+          if (event.key == "y") return window.scrollBy(0, (inputCount ?? 1) * -scrollIncrement);
+        } else {
+          if (event.key == "j") return browserUI.moveCursor(inputCount ?? 1);
+          if (event.key == "k") return browserUI.moveCursor(-(inputCount ?? 1));
+          if (event.key == "J") return browserUI.moveTask(inputCount ?? 1);
+          if (event.key == "K") return browserUI.moveTask(-(inputCount ?? 1));
+          if (event.key == "G") return browserUI.jumpCursor(inputCount ?? MAX_SAFE_INTEGER);
+          if (event.key == "T") return browserUI.makeTopPriority();
+          if (event.key == "n") return browserUI.focusTaskNameInput(event);
+          if (event.key == "c") return browserUI.setState("cancelled");
+          if (event.key == "d") return browserUI.setState("done");
+          if (event.key == "q") return browserUI.setState("todo");
+          if (event.key == "s") return (inputState = InputState.S);
+          if (event.key == "w") return browserUI.setState("waiting");
+          if (event.key == "X") return browserUI.setState("deleted");
+          if (event.key == "x") return browserUI.removeTag();
+          if (event.key == "u") return browserUI.undo();
+          if (event.key == "r") return browserUI.redo();
+          if (event.key == "e") return browserUI.beginEdit(event);
+          if (event.key == "t") return browserUI.beginTagEdit(event);
+          if (event.key == "v") return (inputState = InputState.V);
+        }
       } finally {
         inputCount = null;
       }