Split setTagView() to factor out setTagFilter()

[vopamoi] / vopamoi.ts

diff --git a/vopamoi.ts b/vopamoi.ts
index 47c421df5d9507951bafa547f9e090e16d6cf052..1d357bd50b8a039224d15cb6ec72e29bd202d697 100644 (file)
--- a/vopamoi.ts
+++ b/vopamoi.ts
@@ -320,7 +320,7 @@ function BrowserUI() {
     todo: "White",
     waiting: "MediumOrchid",
   };
-  var currentTagView: string | null = null;
+  var currentTagFilter: string | null = null;
   var currentViewState = "todo";
   var taskFocusedBeforeJumpingToInput: HTMLElement | null = null;
   var lastTagNameEntered = "";
@@ -561,7 +561,7 @@ function BrowserUI() {
     },
 
     resetTagView: function () {
-      currentTagView = null;
+      currentTagFilter = null;
       this.setTitle();
       const taskList = document.getElementById("tasks")!;
       for (const task of Array.from(document.getElementsByClassName("task"))) {
@@ -611,14 +611,8 @@ function BrowserUI() {
       return ui.setState(createTimestamp, newState, oldState);
     },
 
-    setTagView: function (tag: string | null = null) {
-      if (tag === null) {
-        const target = this.currentTag();
-        if (!target) return;
-        tag = target.textContent!;
-      }
-
-      if (currentTagView !== null) {
+    setTagFilter: function (tag: string) {
+      if (currentTagFilter !== null) {
         this.resetTagView();
       }
 
@@ -655,12 +649,21 @@ function BrowserUI() {
         }
       }
 
-      currentTagView = tag;
+      currentTagFilter = tag;
       this.setTitle();
     },
 
+    setTagView: function (tag: string | null = null) {
+      if (tag === null) {
+        const target = this.currentTag();
+        if (!target) return;
+        tag = target.textContent!;
+      }
+      this.setTagFilter(tag);
+    },
+
     setTitle: function () {
-      document.title = "Vopamoi: " + currentViewState + (currentTagView ? ": " + currentTagView : "");
+      document.title = "Vopamoi: " + currentViewState + (currentTagFilter ? ": " + currentTagFilter : "");
     },
 
     setView: function (state: string) {
@@ -681,7 +684,7 @@ function BrowserUI() {
     },
 
     setUntaggedView: function () {
-      if (currentTagView !== null) {
+      if (currentTagFilter !== null) {
         this.resetTagView();
       }
       for (const task of document.getElementsByClassName("task")) {