From e8a53974ae88e0bbe0d616be7d53aa060b4ed80d Mon Sep 17 00:00:00 2001 From: Scott Worley Date: Tue, 10 Oct 2023 01:27:46 -0700 Subject: [PATCH 1/1] client: const config --- client/config.c | 20 ++++++++++---------- client/config.h | 20 ++++++++++---------- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/client/config.c b/client/config.c index 0e1a86d..83a3eb3 100644 --- a/client/config.c +++ b/client/config.c @@ -1,29 +1,29 @@ #include "config.h" /* Wi-Fi credentials */ -char config_wifi_ssid[] = "THEWIFISSID"; -char config_wifi_pass[] = "THEWIFIPASSWORD"; +const char config_wifi_ssid[] = "THEWIFISSID"; +const char config_wifi_pass[] = "THEWIFIPASSWORD"; /* Network address of the server to contact */ -char config_tattle_server_ip_address[] = "192.168.10.10"; -u16_t config_tattle_port = 29803; // 'tk' +const char config_tattle_server_ip_address[] = "192.168.10.10"; +const u16_t config_tattle_port = 29803; // 'tk' /* For distinguishing reports from multiple tattlekey devices. */ -u16_t config_this_tattler_identity = 1; +const u16_t config_this_tattler_identity = 1; /* Which GPIO pin is the button connected to? * The button should span this pin and ground, connecting this pin to ground * when pressed. * https://projects.raspberrypi.org/en/projects/introduction-to-the-pico/10 * recommends pins 18, 22, or 28. */ -uint config_button_pin = 18; +const uint config_button_pin = 18; /* Don't bother reporting each separate button press when it is pressed many * times in short succession. (We also use this to de-bounce. :) */ -u32_t config_minimum_seconds_between_button_presses = 1; +const u32_t config_minimum_seconds_between_button_presses = 1; /* Send each report multiple times. */ -uint config_resend_count = 5; +const uint config_resend_count = 5; /* These control the size of the per-send-count press queues. When the button is pressed more than config_maximum_queue_size times @@ -33,9 +33,9 @@ the old, longest-delayed, most-redundant reports that get dropped; fresh, timely reports of new button presses will not get anywhere near config_resend_count in a resend interval because the early resend internals are so short. */ -uint config_maximum_queue_size = 512; +const uint config_maximum_queue_size = 512; /* This is paranoia about unanticipated delays. Setting this to zero would probably be fine, but imposing a minimum queue size is an easy safety measure. */ -uint config_minimum_queue_size = 32; +const uint config_minimum_queue_size = 32; diff --git a/client/config.h b/client/config.h index 23f04d5..ee3dba8 100644 --- a/client/config.h +++ b/client/config.h @@ -4,29 +4,29 @@ #include "lwip/arch.h" /* Wi-Fi credentials */ -extern char config_wifi_ssid[]; -extern char config_wifi_pass[]; +extern const char config_wifi_ssid[]; +extern const char config_wifi_pass[]; /* Network address of the server to contact */ -extern char config_tattle_server_ip_address[]; -extern u16_t config_tattle_port; +extern const char config_tattle_server_ip_address[]; +extern const u16_t config_tattle_port; /* For distinguishing reports from multiple tattlekey devices. */ -extern u16_t config_this_tattler_identity; +extern const u16_t config_this_tattler_identity; /* Which GPIO pin is the button connected to? * The button should span this pin and ground, connecting this pin to ground * when pressed. * https://projects.raspberrypi.org/en/projects/introduction-to-the-pico/10 * recommends pins 18, 22, or 28. */ -extern uint config_button_pin; +extern const uint config_button_pin; /* Don't bother reporting each separate button press when it is pressed many * times in short succession. (We also use this to de-bounce. :) */ -extern u32_t config_minimum_seconds_between_button_presses; +extern const u32_t config_minimum_seconds_between_button_presses; /* Send each report multiple times. */ -extern uint config_resend_count; +extern const uint config_resend_count; /* These control the size of the per-send-count press queues. When the button is pressed more than config_maximum_queue_size times @@ -36,11 +36,11 @@ the old, longest-delyed, most-redundant reports that get dropped; fresh, timely reports of new button presses will not get anywhere near config_resend_count in a resend interval because the early resend interals are so short. */ -extern uint config_maximum_queue_size; +extern const uint config_maximum_queue_size; /* This is paranoia about unanticipated delays. Setting this to zero would pobably be fine, but imposing a minimum queue size is an easy safety measure. */ -extern uint config_minimum_queue_size; +extern const uint config_minimum_queue_size; #endif -- 2.44.1