From: Scott Worley <scottworley@scottworley.com>
Date: Mon, 9 Oct 2023 19:34:29 +0000 (-0700)
Subject: client: queue_try_add_ignoring_errors()
X-Git-Tag: v0.1.0~49
X-Git-Url: http://git.scottworley.com/tattlekey/commitdiff_plain/07b39467ab6efc8ad5d9510bf5ebf06c9679ed4e?ds=sidebyside

client: queue_try_add_ignoring_errors()
---

diff --git a/client/tattlekey.c b/client/tattlekey.c
index aadf49d..352b84c 100644
--- a/client/tattlekey.c
+++ b/client/tattlekey.c
@@ -21,6 +21,17 @@ queue_t queue;
 
 uint32_t time_s() { return time_us_64() / 1000000ul; }
 
+/* Often we don't bother checking for failure (full queue) because
+ *   1. The best thing to do in this unfortunate situation is to blithely
+ *      continue, dropping some events; continuing is better than stopping.
+ *   2. Neither interrupt context nor queue-processing context can block
+ *      until space is available, or even sit around & blink the LED to
+ *      signal a problem.
+ * (We also get a bit of type safety by taking event_t* rather than void*.) */
+static void queue_try_add_ignoring_errors(queue_t *q, event_t *e) {
+  queue_try_add(q, e);
+}
+
 static void button_pressed() {
   /* This runs in interrupt context; don't linger.  */
   static uint64_t last_button_press_time = 0;
@@ -31,9 +42,7 @@ static void button_pressed() {
     event_t e;
     e.type = BUTTONPRESS;
     e.buttonpress.timestamp = now;
-    /* We don't check for failure (full queue) here because there's not much to
-     * be done about it. */
-    queue_try_add(&queue, &e);
+    queue_try_add_ignoring_errors(&queue, &e);
   }
 }