client: queue_try_add_ignoring_errors()

[tattlekey] / client / tattlekey.c

diff --git a/client/tattlekey.c b/client/tattlekey.c
index 9e7b4b598d9c5d0f5c6c9e4a6e77c9d3845eaa65..352b84c4be8ec35987beb68ad6a4581332b62064 100644 (file)
--- a/client/tattlekey.c
+++ b/client/tattlekey.c
@@ -7,19 +7,42 @@
 #include "config.h"
 #include "net.h"
 
+enum event_type { BUTTONPRESS };
+typedef struct {
+  enum event_type type;
+  union {
+    struct {
+      uint32_t timestamp;
+    } buttonpress;
+  };
+} event_t;
+
 queue_t queue;
 
+uint32_t time_s() { return time_us_64() / 1000000ul; }
+
+/* Often we don't bother checking for failure (full queue) because
+ *   1. The best thing to do in this unfortunate situation is to blithely
+ *      continue, dropping some events; continuing is better than stopping.
+ *   2. Neither interrupt context nor queue-processing context can block
+ *      until space is available, or even sit around & blink the LED to
+ *      signal a problem.
+ * (We also get a bit of type safety by taking event_t* rather than void*.) */
+static void queue_try_add_ignoring_errors(queue_t *q, event_t *e) {
+  queue_try_add(q, e);
+}
+
 static void button_pressed() {
   /* This runs in interrupt context; don't linger.  */
   static uint64_t last_button_press_time = 0;
-  uint64_t now = time_us_64();
-  uint64_t time_since_last_press = now - last_button_press_time;
-  if (time_since_last_press > minimum_microseconds_between_button_presses) {
+  uint32_t now = time_s();
+  uint32_t time_since_last_press = now - last_button_press_time;
+  if (time_since_last_press >= config_minimum_seconds_between_button_presses) {
     last_button_press_time = now;
-    char zero = '\0';
-    /* We don't check for failure (full queue) here because there's not much to
-     * be done about it. */
-    queue_try_add(&queue, &zero);
+    event_t e;
+    e.type = BUTTONPRESS;
+    e.buttonpress.timestamp = now;
+    queue_try_add_ignoring_errors(&queue, &e);
   }
 }
 
@@ -29,24 +52,32 @@ int main() {
     signal_error_by_blinking();
   cyw43_arch_enable_sta_mode();
   signal(3, 100);
-  if (cyw43_arch_wifi_connect_timeout_ms(wifi_ssid, wifi_pass,
+  if (cyw43_arch_wifi_connect_timeout_ms(config_wifi_ssid, config_wifi_pass,
                                          CYW43_AUTH_WPA2_AES_PSK, 90000))
     signal_error_by_blinking();
   signal(2, 300);
 
-  queue_init(&queue, 1, 99);
+  queue_init(&queue, sizeof(event_t), 99);
 
   begin_listening_for_button_press(button_pressed);
 
   u16_t seq = 0;
   while (1) {
-    char _;
-    queue_remove_blocking(&queue, &_);
-    seq++;
-    for (int i = 0; i < resend_count; i++) {
-      send_report(seq, i);
-      signal(i == 0 ? 2 : 1, 100);
-      sleep_ms(resend_interval_ms);
+    event_t e;
+    queue_remove_blocking(&queue, &e);
+    switch (e.type) {
+    case BUTTONPRESS:
+      seq++;
+      for (int i = 0; i < config_resend_count; i++) {
+        uint32_t now = time_s();
+        uint32_t ago = now - e.buttonpress.timestamp;
+        send_report(seq, ago);
+        signal(i == 0 ? 2 : 1, 100);
+        sleep_ms(config_resend_interval_ms);
+      }
+      break;
+    default:
+      signal_error_by_blinking();
     }
   }
 }