client: Extract set_send_alarm()

[tattlekey] / client / tattlekey.c

diff --git a/client/tattlekey.c b/client/tattlekey.c
index 9af9b5aef2f12e8e7147035f844af1d8aac557ef..c600448cdb590cf56ace165347b09ce8d127bcd0 100644 (file)
--- a/client/tattlekey.c
+++ b/client/tattlekey.c
@@ -7,20 +7,7 @@
 #include "button.h"
 #include "config.h"
 #include "net.h"
-
-typedef struct {
-  uint32_t timestamp;
-  u16_t seq;
-  u8_t send_count;
-} send_t;
-
-uint32_t next_send(send_t *s) { return s->timestamp + s->send_count; }
-
-bool next_send_less_than(void *user_data, pheap_node_id_t a,
-                         pheap_node_id_t b) {
-  send_t *sends = (send_t *)user_data;
-  return next_send(&sends[a]) < next_send(&sends[b]);
-}
+#include "sends.h"
 
 enum event_type { BUTTONPRESS, SEND };
 typedef struct {
@@ -68,24 +55,28 @@ static void time_to_send(uint _) {
   queue_try_add_ignoring_errors(&queue, &e);
 }
 
+void set_send_alarm(int alarm, uint32_t now, uint32_t next_act_time) {
+  uint32_t sleep_duration = next_act_time - now;
+  if (hardware_alarm_set_target(alarm,
+                                make_timeout_time_ms(sleep_duration * 1000)))
+    signal_error_by_blinking();
+  return;
+}
+
 void service_sleeps(int alarm, send_t *sleeping_sends, pheap_t *sleeps_heap) {
   hardware_alarm_cancel(alarm);
 
   while (1) {
     uint32_t now = time_s();
-    pheap_node_id_t i = ph_peek_head(sleeps_heap);
-    if (i == 0)
+    int32_t act_time = next_scheduled_send(sleeping_sends, sleeps_heap);
+    if (act_time == -1)
       return;
-    send_t *send = &sleeping_sends[i];
-    if (next_send(send) > now) {
-      uint32_t sleep_duration = next_send(send) - now;
-      if (hardware_alarm_set_target(
-              alarm, make_timeout_time_ms(sleep_duration * 1000)))
-        signal_error_by_blinking();
+    if (act_time > now) {
+      set_send_alarm(alarm, now, act_time);
       return;
     }
-    if (ph_remove_head(sleeps_heap, false) != i)
-      signal_error_by_blinking();
+    pheap_node_id_t i = ph_remove_head(sleeps_heap, false);
+    send_t *send = &sleeping_sends[i];
     uint32_t ago = now - send->timestamp;
     send_report(send->seq, ago);
     send->send_count++;
@@ -113,16 +104,7 @@ void service_queue() {
     queue_remove_blocking(&queue, &e);
     switch (e.type) {
     case BUTTONPRESS: {
-      pheap_node_id_t i = ph_new_node(sleeps_heap);
-      if (i == 0) {
-        /* TODO: Don't drop new presses just because sleeps_heap is full of old
-         * presses. */
-        break;
-      }
-      sleeping_sends[i].timestamp = e.buttonpress.timestamp;
-      sleeping_sends[i].seq = seq++;
-      sleeping_sends[i].send_count = 0;
-      ph_insert_node(sleeps_heap, i);
+      create_send(sleeping_sends, sleeps_heap, e.buttonpress.timestamp, seq++);
     } break;
     case SEND: {
       /* OK, we're awake. Cool. Thanks! (We actually do the sends in the