client: lint nits

[tattlekey] / client / press.c

diff --git a/client/press.c b/client/press.c
index 49b2b9a875eb9473c1b794de0be1eb976fe8338f..b9f01ef1d4c4ddebb869eb3605cd73cfb9686806 100644 (file)
--- a/client/press.c
+++ b/client/press.c
@@ -1,32 +1,81 @@
 #include "press.h"
+#include "blink.h"
+#include "config.h"
 
-static uint32_t next_send(press_t *s) {
+static uint32_t press_next_send(press_t *s) {
   return s->timestamp + (1 << s->send_count) - 1;
 }
 
-bool next_send_less_than(void *user_data, pheap_node_id_t a,
-                         pheap_node_id_t b) {
-  press_t *presses = (press_t *)user_data;
-  return next_send(&presses[a]) < next_send(&presses[b]);
+static uint32_t press_queue_next_send(queue_t *q) {
+  press_t press;
+  return queue_try_peek(q, &press) ? press_next_send(&press) : UINT32_MAX;
 }
 
-void create_press(press_t *presses, pheap_t *sleeps_heap, uint32_t timestamp,
-                  u16_t seq) {
-  pheap_node_id_t i = ph_new_node(sleeps_heap);
-  if (i == 0) {
-    /* TODO: Don't drop new presses just because sleeps_heap is full of old
-     * presses. */
-    return;
+static bool next_send_less_than(void *user_data, pheap_node_id_t a,
+                                pheap_node_id_t b) {
+  queue_t **sleeps = (queue_t **)user_data;
+  return press_queue_next_send(sleeps[a]) < press_queue_next_send(sleeps[b]);
+}
+
+static void *xcalloc(size_t nmemb, size_t size) {
+  void *p = calloc(nmemb, size);
+  if (p == NULL)
+    signal_error_by_blinking();
+  return p;
+}
+
+press_pile_t *create_press_pile() {
+  press_pile_t *pp = (press_pile_t *)xcalloc(1, sizeof(press_pile_t));
+  pp->presses = (queue_t *)xcalloc(config_resend_count, sizeof(queue_t));
+  pp->sleeps = (queue_t **)xcalloc(config_resend_count, sizeof(queue_t *));
+  for (uint i = 0; i < config_resend_count; i++) {
+    const uint paranoid_safety_fudge = 10;
+    uint element_count = paranoid_safety_fudge + (1 << i);
+    element_count = MAX(element_count, config_minimum_queue_size);
+    element_count = MIN(element_count, config_maximum_queue_size);
+    queue_init(&pp->presses[i], sizeof(press_t), element_count);
+  }
+  pp->sleeps_heap =
+      ph_create(config_resend_count, next_send_less_than, pp->sleeps);
+  if (pp->sleeps_heap == NULL)
+    signal_error_by_blinking();
+  return pp;
+}
+
+void add_press(press_pile_t *pp, press_t *press) {
+  u16_t sc = press->send_count;
+  if (sc >= config_resend_count)
+    signal_error_by_blinking();
+  bool was_empty = queue_is_empty(&pp->presses[sc]);
+  /* No error check; blithely continue if the queue was full. */
+  queue_try_add(&pp->presses[sc], press);
+  if (was_empty) {
+    pheap_node_id_t i = ph_new_node(pp->sleeps_heap);
+    pp->sleeps[i] = &pp->presses[sc];
+    ph_insert_node(pp->sleeps_heap, i);
   }
-  presses[i].timestamp = timestamp;
-  presses[i].seq = seq;
-  presses[i].send_count = 0;
-  ph_insert_node(sleeps_heap, i);
 }
 
-int32_t next_scheduled_send(press_t *presses, pheap_t *sleeps_heap) {
-  pheap_node_id_t i = ph_peek_head(sleeps_heap);
+int32_t next_scheduled_send(press_pile_t *pp) {
+  pheap_node_id_t i = ph_peek_head(pp->sleeps_heap);
   if (i == 0)
     return -1;
-  return next_send(&presses[i]);
+  return press_queue_next_send(pp->sleeps[i]);
+}
+
+bool get_press_due_for_resend(press_pile_t *pp, uint32_t now, press_t *press) {
+  pheap_node_id_t i = ph_peek_head(pp->sleeps_heap);
+  if (i == 0 || press_queue_next_send(pp->sleeps[i]) > now)
+    return false;
+  if (!queue_try_remove(pp->sleeps[i], press))
+    signal_error_by_blinking();
+  bool became_empty = queue_is_empty(pp->sleeps[i]);
+  if (ph_remove_head(pp->sleeps_heap, became_empty) != i)
+    signal_error_by_blinking();
+  if (became_empty) {
+    pp->sleeps[i] = NULL;
+  } else {
+    ph_insert_node(pp->sleeps_heap, i);
+  }
+  return true;
 }