From: Scott Worley Date: Fri, 4 Oct 2024 21:28:07 +0000 (-0700) Subject: `!label col:new label` to substitute a different label for a column X-Git-Tag: v0.5.0~5 X-Git-Url: http://git.scottworley.com/tablify/commitdiff_plain/d669f60d11bad036e4ac6c3da39f067d7bd2153a?hp=e3feb9dc125d96673d3947c925dd7f1986e16416 `!label col:new label` to substitute a different label for a column --- diff --git a/Changelog b/Changelog index 212e410..cab5053 100644 --- a/Changelog +++ b/Changelog @@ -1,4 +1,5 @@ ## [Unreleased] +- `!label col:new label` to substitute a different label for a column ## [0.4.0] - 2024-10-03 - Read column threshold from `!col_threshold ` in input diff --git a/src/lib.rs b/src/lib.rs index 88c6d8c..f5d12f8 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -9,6 +9,7 @@ struct Config { column_threshold: usize, static_columns: Vec>, hidden_columns: HashSet, + substitute_labels: HashMap, } impl Config { fn apply_command(&mut self, line_num: usize, cmd: &str) -> Result<(), std::io::Error> { @@ -25,6 +26,18 @@ impl Config { self.static_columns.push(Some(col.to_owned())); } else if cmd == "colsep" { self.static_columns.push(None); + } else if let Some(directive) = cmd.strip_prefix("label ") { + match directive.split_once(':') { + None => { + return Err(std::io::Error::new( + std::io::ErrorKind::InvalidInput, + format!("line {line_num}: Annotation missing ':'"), + )) + } + Some((col, label)) => self + .substitute_labels + .insert(col.to_owned(), label.to_owned()), + }; } else { return Err(std::io::Error::new( std::io::ErrorKind::InvalidInput, @@ -40,6 +53,7 @@ impl Default for Config { column_threshold: 2, static_columns: vec![], hidden_columns: HashSet::new(), + substitute_labels: HashMap::new(), } } } @@ -365,9 +379,15 @@ fn column_header_labels<'a>( ) -> impl Iterator> { let static_columns = config.static_columns.iter().map(|oc| oc.as_ref()); let dynamic_columns = columns.iter().map(Some); - static_columns.chain(dynamic_columns).filter(|ocol| { - ocol.map_or(true, |col| !config.hidden_columns.contains(col)) - }) + static_columns + .chain(dynamic_columns) + .filter(|ocol| ocol.map_or(true, |col| !config.hidden_columns.contains(col))) + .map(|ocol| { + ocol.map(|col| match config.substitute_labels.get(col) { + None => col, + Some(substitute) => substitute, + }) + }) } fn render_column_headers(config: &Config, columns: &[String]) -> HTML { @@ -563,6 +583,12 @@ mod tests { read_config(&b"!col foo"[..]).unwrap().static_columns, vec![Some("foo".to_owned())] ); + assert_eq!( + read_config(&b"!label foo:bar"[..]) + .unwrap() + .substitute_labels["foo"], + "bar" + ); let bad_command = read_config(&b"!no such command"[..]); assert!(bad_command.is_err()); @@ -571,6 +597,10 @@ mod tests { let bad_num = read_config(&b"!col_threshold foo"[..]); assert!(bad_num.is_err()); assert!(format!("{bad_num:?}").contains("line 1: col_threshold must be numeric")); + + let bad_sub = read_config(&b"!label foo"[..]); + assert!(bad_sub.is_err()); + assert!(format!("{bad_sub:?}").contains("line 1: Annotation missing ':'")); } #[test] @@ -612,6 +642,14 @@ mod tests { Some(&"foo".to_owned()) ])); + cfg.substitute_labels + .insert("foo".to_owned(), "foo (bits)".to_owned()); + assert!(column_header_labels(&cfg, &["foo".to_owned()]).eq([ + Some(&"bar".to_owned()), + None, + Some(&"foo (bits)".to_owned()) + ])); + cfg.hidden_columns.insert("foo".to_owned()); assert!(column_header_labels(&cfg, &["foo".to_owned()]).eq([Some(&"bar".to_owned()), None])); @@ -780,6 +818,7 @@ mod tests { column_threshold: 2, static_columns: vec![], hidden_columns: HashSet::from(["private".to_owned()]), + substitute_labels: HashMap::new(), }, &Row { label: "nope".to_owned(), @@ -812,6 +851,7 @@ mod tests { column_threshold: 0, static_columns: vec![Some("foo".to_owned()), Some("bar".to_owned())], hidden_columns: HashSet::new(), + substitute_labels: HashMap::new(), }, &["baz".to_owned()], &mut Rowlike::Row(Row { @@ -834,6 +874,7 @@ mod tests { column_threshold: 0, static_columns: vec![Some("foo".to_owned()), None, Some("bar".to_owned())], hidden_columns: HashSet::new(), + substitute_labels: HashMap::new(), }, &[], &mut Rowlike::Row(Row { @@ -855,6 +896,7 @@ mod tests { column_threshold: 0, static_columns: vec![], hidden_columns: HashSet::from(["foo".to_owned()]), + substitute_labels: HashMap::new(), }, &[], &mut Rowlike::Row(Row { @@ -873,6 +915,7 @@ mod tests { column_threshold: 0, static_columns: vec![Some("foo".to_owned())], hidden_columns: HashSet::from(["foo".to_owned()]), + substitute_labels: HashMap::new(), }, &[], &mut Rowlike::Row(Row {