X-Git-Url: http://git.scottworley.com/tablify/blobdiff_plain/f272e502c4d1e2e33ab1e9fe460df69ff8f8ccd2..4b99fb70fa61addf2373a460d6d5c7fe82e19f5a:/src/lib.rs?ds=sidebyside

diff --git a/src/lib.rs b/src/lib.rs
index e90f66b..8d60eb8 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -1,8 +1,5 @@
-#[cfg(test)]
-use std::collections::HashMap;
-#[cfg(test)]
+use std::collections::{HashMap, HashSet};
 use std::io::BufRead;
-#[cfg(test)]
 use std::iter::Iterator;
 
 #[derive(Debug, PartialEq, Eq)]
@@ -16,7 +13,6 @@ struct Reader<Input: Iterator<Item = Result<String, std::io::Error>>> {
     row: Option<RowInput>,
 }
 impl<Input: Iterator<Item = Result<String, std::io::Error>>> Reader<Input> {
-    #[cfg(test)]
     fn new(input: Input) -> Self {
         Self {
             input: input.enumerate(),
@@ -63,26 +59,37 @@ impl<Input: Iterator<Item = Result<String, std::io::Error>>> Iterator for Reader
     }
 }
 
-#[cfg(test)]
 fn read_rows(input: impl std::io::Read) -> impl Iterator<Item = Result<RowInput, std::io::Error>> {
     Reader::new(std::io::BufReader::new(input).lines())
 }
 
-#[cfg(test)]
-fn column_counts(rows: &[RowInput]) -> HashMap<String, usize> {
-    rows.iter()
-        .flat_map(|r| r.entries.iter())
-        .fold(HashMap::new(), |mut counts, e| {
-            counts
-                .entry(String::from(e))
-                .and_modify(|c| *c += 1)
+fn column_counts(rows: &[RowInput]) -> Vec<(usize, String)> {
+    let mut counts: Vec<_> = rows
+        .iter()
+        .flat_map(|r| r.entries.iter().collect::<HashSet<_>>().into_iter())
+        .fold(HashMap::new(), |mut cs, e| {
+            cs.entry(String::from(e))
+                .and_modify(|n| *n += 1)
                 .or_insert(1);
-            counts
+            cs
         })
+        .into_iter()
+        .map(|(col, n)| (n, col))
+        .collect();
+    counts.sort();
+    counts
 }
 
-pub fn tablify(_input: &impl std::io::Read) -> String {
-    String::from("Hello, world!")
+/// # Errors
+///
+/// Will return `Err` if
+///   * there's an i/o error while reading `input`
+///   * the log has invalid syntax:
+///     * an indented line with no preceding non-indented line
+pub fn tablify(input: impl std::io::Read) -> Result<String, std::io::Error> {
+    let rows = read_rows(input).collect::<Result<Vec<_>, _>>()?;
+    let _columns = column_counts(&rows);
+    Ok(String::from("Hello, world!"))
 }
 
 #[cfg(test)]
@@ -191,7 +198,7 @@ mod tests {
                     .collect::<Result<Vec<_>, _>>()
                     .unwrap()
             ),
-            HashMap::from([(String::from("bar"), 1), (String::from("baz"), 1)])
+            vec![(1, String::from("bar")), (1, String::from("baz"))]
         );
         assert_eq!(
             column_counts(
@@ -199,7 +206,15 @@ mod tests {
                     .collect::<Result<Vec<_>, _>>()
                     .unwrap()
             ),
-            HashMap::from([(String::from("bar"), 1), (String::from("baz"), 2)])
+            vec![(1, String::from("bar")), (2, String::from("baz"))]
+        );
+        assert_eq!(
+            column_counts(
+                &read_rows(&b"foo\n bar\n bar\n baz\n bar\nquux\n baz"[..])
+                    .collect::<Result<Vec<_>, _>>()
+                    .unwrap()
+            ),
+            vec![(1, String::from("bar")), (2, String::from("baz"))]
         );
     }
 }