From: Scott Worley Date: Mon, 6 Oct 2025 06:33:38 +0000 (-0700) Subject: Factor out Stream.start() X-Git-Url: http://git.scottworley.com/srec/commitdiff_plain/e5b09945620ccdc8759cf6fe8f885854b6837596?hp=b3399b18f91a2f2e12ac9858f8f8e008a60138cd Factor out Stream.start() --- diff --git a/srec.py b/srec.py index 8207c91..944cc5c 100644 --- a/srec.py +++ b/srec.py @@ -4,6 +4,8 @@ # under the terms of the GNU General Public License as published by the # Free Software Foundation, version 3. +from __future__ import annotations + from dataclasses import dataclass from datetime import datetime import os @@ -23,6 +25,11 @@ from gi.repository import GLib # nopep8 pylint: disable=wrong-import-position class Stream: process: subprocess.Popen[bytes] + @staticmethod + def start(command: list[str]) -> Stream: + # pylint: disable=consider-using-with + return Stream(process=subprocess.Popen(command, stdin=subprocess.PIPE)) + def stop(self) -> None: stdin = self.process.stdin assert stdin is not None @@ -83,11 +90,9 @@ def on_start_recording(_: Gtk.Button, stack: Gtk.Stack) -> None: return GLib.SOURCE_REMOVE if recording is None else GLib.SOURCE_CONTINUE GLib.timeout_add_seconds(1, update_size_display) - command = (['ffmpeg', '-framerate', '25'] + video_source(stack) + - ['-f', 'pulse', '-ac', '2', '-i', 'default', filename]) - # pylint: disable=consider-using-with - recording = Stream( - process=subprocess.Popen(command, stdin=subprocess.PIPE)) + recording = Stream.start( + ['ffmpeg', '-framerate', '25'] + video_source(stack) + + ['-f', 'pulse', '-ac', '2', '-i', 'default', filename]) stack.set_visible_child_name("recording")