Factor out Stream.start()

[srec] / srec.py

diff --git a/srec.py b/srec.py
index 8207c91352fa434fdc32c6ebf971bec236d4cafe..944cc5cccd387587d86466a2389383023c5bf230 100644 (file)
--- a/srec.py
+++ b/srec.py
@@ -4,6 +4,8 @@
 # under the terms of the GNU General Public License as published by the
 # Free Software Foundation, version 3.
 
 # under the terms of the GNU General Public License as published by the
 # Free Software Foundation, version 3.
 

+from __future__ import annotations
+

 from dataclasses import dataclass
 from datetime import datetime
 import os
 from dataclasses import dataclass
 from datetime import datetime
 import os


@@ -23,6 +25,11 @@ from gi.repository import GLib  # nopep8 pylint: disable=wrong-import-position
 class Stream:
     process: subprocess.Popen[bytes]
 
 class Stream:
     process: subprocess.Popen[bytes]
 

+    @staticmethod
+    def start(command: list[str]) -> Stream:
+        # pylint: disable=consider-using-with
+        return Stream(process=subprocess.Popen(command, stdin=subprocess.PIPE))
+

     def stop(self) -> None:
         stdin = self.process.stdin
         assert stdin is not None
     def stop(self) -> None:
         stdin = self.process.stdin
         assert stdin is not None


@@ -83,11 +90,9 @@ def on_start_recording(_: Gtk.Button, stack: Gtk.Stack) -> None:
         return GLib.SOURCE_REMOVE if recording is None else GLib.SOURCE_CONTINUE
     GLib.timeout_add_seconds(1, update_size_display)
 
         return GLib.SOURCE_REMOVE if recording is None else GLib.SOURCE_CONTINUE
     GLib.timeout_add_seconds(1, update_size_display)
 

-    command = (['ffmpeg', '-framerate', '25'] + video_source(stack) +
-               ['-f', 'pulse', '-ac', '2', '-i', 'default', filename])
-    # pylint: disable=consider-using-with
-    recording = Stream(
-        process=subprocess.Popen(command, stdin=subprocess.PIPE))
+    recording = Stream.start(
+        ['ffmpeg', '-framerate', '25'] + video_source(stack) +
+        ['-f', 'pulse', '-ac', '2', '-i', 'default', filename])

     stack.set_visible_child_name("recording")
 
 
     stack.set_visible_child_name("recording")