Don't hang if ffmpeg exits on its own

[srec] / srec.py

diff --git a/srec.py b/srec.py
index 01b5a8ca7ec1200aff08d41fe85e718f224f5341..e9054838af18172c5e785162eab43c62dd7c1934 100644 (file)
--- a/srec.py
+++ b/srec.py
@@ -8,6 +8,7 @@ from dataclasses import dataclass
 from datetime import datetime
 import os
 import subprocess
+import sys
 from typing import Any, Callable
 
 import gi
@@ -20,9 +21,18 @@ from gi.repository import GLib  # nopep8 pylint: disable=wrong-import-position
 
 @dataclass
 class Recording:
-    filename: str
     process: subprocess.Popen[bytes]
 
+    def stop(self) -> None:
+        stdin = self.process.stdin
+        assert stdin is not None
+        try:
+            stdin.write(b'q')
+            stdin.flush()
+        except BrokenPipeError:
+            print("Stream already stopped?", file=sys.stderr)
+        self.process.wait()
+
 
 recording: Recording | None = None
 
@@ -77,7 +87,6 @@ def on_start_recording(_: Gtk.Button, stack: Gtk.Stack) -> None:
                ['-f', 'pulse', '-ac', '2', '-i', 'default', filename])
     # pylint: disable=consider-using-with
     recording = Recording(
-        filename=filename,
         process=subprocess.Popen(command, stdin=subprocess.PIPE))
     stack.set_visible_child_name("recording")
 
@@ -85,11 +94,7 @@ def on_start_recording(_: Gtk.Button, stack: Gtk.Stack) -> None:
 def on_stop_recording(_: Gtk.Button, stack: Gtk.Stack) -> None:
     global recording  # pylint: disable=global-statement
     assert recording is not None
-    stdin = recording.process.stdin
-    assert stdin is not None
-    stdin.write(b'q')
-    stdin.flush()
-    recording.process.wait()
+    recording.stop()
     recording = None
     stack.set_visible_child_name("not_recording")