From b7ef1dd6ddcede847ace6ab25fe05cf728cc6a44 Mon Sep 17 00:00:00 2001 From: Scott Worley Date: Wed, 24 Jan 2024 18:42:46 -0800 Subject: [PATCH] Allow more specific invalid symlinks At some point, we may want to just examine incomparable files & allow identically-broken symlinks, rather than explicitly list approved exceptions here. --- Changelog | 1 + pinch.py | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Changelog b/Changelog index b1f8cf1..4507467 100644 --- a/Changelog +++ b/Changelog @@ -1,4 +1,5 @@ ## [Unreleased] +- Allow nixpkgs' additional new intentionally-invalid symlinks ## [3.0.12] - 2023-12-07 diff --git a/pinch.py b/pinch.py index bda7633..e20d5d1 100644 --- a/pinch.py +++ b/pinch.py @@ -432,6 +432,8 @@ def compare_tarball_and_git( 'programs.sqlite', 'svn-revision'] permitted_errors = [ + 'pkgs/test/nixpkgs-check-by-name/tests/multiple-failures/pkgs/by-name/A/fo@/foo', + 'pkgs/test/nixpkgs-check-by-name/tests/symlink-invalid/pkgs/by-name/fo/foo/foo', 'pkgs/test/nixpkgs-check-by-name/tests/symlink-invalid/pkgs/by-name/fo/foo/foo.nix', ] benign_expected_errors = [] -- 2.44.1