From a2290fb189bee1da5e985d785e044d1681401ff7 Mon Sep 17 00:00:00 2001
From: Scott Worley <scottworley@scottworley.com>
Date: Fri, 22 May 2020 17:55:41 -0700
Subject: [PATCH 1/1] Factor out test setup

---
 test.sh                     |  4 ++-
 tests/alias.sh              | 23 ++++------------
 tests/core.sh               | 21 ++------------
 tests/lib/test-setup.sh     | 26 ++++++++++++++++++
 tests/multi-update.sh       | 28 +++++--------------
 tests/pin-twice.sh          | 21 ++------------
 tests/reject-duplicates.sh  | 55 ++++++++++++-------------------------
 tests/reject-nonancestor.sh | 21 ++------------
 8 files changed, 67 insertions(+), 132 deletions(-)
 create mode 100644 tests/lib/test-setup.sh

diff --git a/test.sh b/test.sh
index 9823458..9485418 100755
--- a/test.sh
+++ b/test.sh
@@ -7,7 +7,9 @@ PARALLELISM=4
 find . -name '*.py' -print0 | xargs -0 mypy --strict --ignore-missing-imports
 
 for test in tests/*;do
-  "$test"
+  if [ ! -d "$test" ];then
+    "$test"
+  fi
 done
 
 find . -name '*_test.py' -print0 | xargs -0 -r -n1 python3
diff --git a/tests/alias.sh b/tests/alias.sh
index c721340..5083999 100755
--- a/tests/alias.sh
+++ b/tests/alias.sh
@@ -1,23 +1,10 @@
 #!/bin/sh
 
-set -e
-
-repo_dir="`mktemp -d`"
-repo="$repo_dir/repo"
-git init "$repo"
-(
-  cd "$repo"
-  echo Contents > test-file
-  git add test-file
-  git commit -m 'Commit message'
-)
-
-conf="`mktemp`"
-cat > "$conf" <<EOF
-[foo]
-git_repo = file://$repo
-git_ref = master
+. ./tests/lib/test-setup.sh
 
+foo_setup
+
+cat >> "$conf" <<EOF
 [bar]
 alias_of = foo
 EOF
@@ -26,7 +13,7 @@ python3 ./pinch.py pin "$conf"
 
 actual_env_command=`python3 ./pinch.py update --dry-run "$conf"`
 
-rm -rf "$repo_dir" "$conf"
+foo_cleanup
 
 expected_env_command_RE='^nix-env --profile /nix/var/nix/profiles/per-user/[^/]+/channels --show-trace --file '\''<nix/unpack-channel.nix>'\'' --install --from-expression '\''f: f \{ name = "(repo-[0-9]{10}-[0-9a-f]{11})"; channelName = "bar"; src = builtins.storePath "/nix/store/.{32}-\1.tar.xz"; \}'\'' '\''f: f \{ name = "\1"; channelName = "foo"; src = builtins.storePath "/nix/store/.{32}-\1.tar.xz"; \}'\''$'
 
diff --git a/tests/core.sh b/tests/core.sh
index 385ae2b..da0d991 100755
--- a/tests/core.sh
+++ b/tests/core.sh
@@ -1,29 +1,14 @@
 #!/bin/sh
 
-set -e
+. ./tests/lib/test-setup.sh
 
-repo_dir="`mktemp -d`"
-repo="$repo_dir/repo"
-git init "$repo"
-(
-  cd "$repo"
-  echo Contents > test-file
-  git add test-file
-  git commit -m 'Commit message'
-)
-
-conf="`mktemp`"
-cat > "$conf" <<EOF
-[foo]
-git_repo = file://$repo
-git_ref = master
-EOF
+foo_setup
 
 python3 ./pinch.py pin "$conf"
 
 actual_env_command=`python3 ./pinch.py update --dry-run "$conf"`
 
-rm -rf "$repo_dir" "$conf"
+foo_cleanup
 
 expected_env_command_RE='^nix-env --profile /nix/var/nix/profiles/per-user/[^/]+/channels --show-trace --file '\''<nix/unpack-channel.nix>'\'' --install --from-expression '\''f: f \{ name = "(repo-[0-9]{10}-[0-9a-f]{11})"; channelName = "foo"; src = builtins.storePath "/nix/store/.{32}-\1.tar.xz"; \}'\''$'
 
diff --git a/tests/lib/test-setup.sh b/tests/lib/test-setup.sh
new file mode 100644
index 0000000..12cf525
--- /dev/null
+++ b/tests/lib/test-setup.sh
@@ -0,0 +1,26 @@
+set -e
+
+foo_setup() {
+
+  repo_dir="`mktemp -d`"
+  repo="$repo_dir/repo"
+  git init "$repo"
+  (
+    cd "$repo"
+    echo Contents > test-file
+    git add test-file
+    git commit -m 'Commit message'
+  )
+
+  conf="`mktemp`"
+  cat > "$conf" <<EOF
+[foo]
+git_repo = file://$repo
+git_ref = master
+EOF
+
+}
+
+foo_cleanup() {
+  rm -rf "$repo_dir" "$conf"
+}
diff --git a/tests/multi-update.sh b/tests/multi-update.sh
index 24c22bc..d6a6d54 100755
--- a/tests/multi-update.sh
+++ b/tests/multi-update.sh
@@ -1,23 +1,8 @@
 #!/bin/sh
 
-set -e
-
-repo_dir="`mktemp -d`"
-repo="$repo_dir/repo"
-git init "$repo"
-(
-  cd "$repo"
-  echo Contents > test-file
-  git add test-file
-  git commit -m 'Commit message'
-)
-
-conf1="`mktemp`"
-cat > "$conf1" <<EOF
-[foo]
-git_repo = file://$repo
-git_ref = master
-EOF
+. ./tests/lib/test-setup.sh
+
+foo_setup
 
 conf2="`mktemp`"
 cat > "$conf2" <<EOF
@@ -25,12 +10,13 @@ cat > "$conf2" <<EOF
 alias_of = foo
 EOF
 
-python3 ./pinch.py pin "$conf1"
+python3 ./pinch.py pin "$conf"
 python3 ./pinch.py pin "$conf2"
 
-actual_env_command=`python3 ./pinch.py update --dry-run "$conf1" "$conf2"`
+actual_env_command=`python3 ./pinch.py update --dry-run "$conf" "$conf2"`
 
-rm -rf "$repo_dir" "$conf1" "$conf2"
+foo_cleanup
+rm -rf "$conf2"
 
 expected_env_command_RE='^nix-env --profile /nix/var/nix/profiles/per-user/[^/]+/channels --show-trace --file '\''<nix/unpack-channel.nix>'\'' --install --from-expression '\''f: f \{ name = "(repo-[0-9]{10}-[0-9a-f]{11})"; channelName = "bar"; src = builtins.storePath "/nix/store/.{32}-\1.tar.xz"; \}'\'' '\''f: f \{ name = "\1"; channelName = "foo"; src = builtins.storePath "/nix/store/.{32}-\1.tar.xz"; \}'\''$'
 
diff --git a/tests/pin-twice.sh b/tests/pin-twice.sh
index b17af2c..5f51cc0 100755
--- a/tests/pin-twice.sh
+++ b/tests/pin-twice.sh
@@ -1,23 +1,8 @@
 #!/bin/sh
 
-set -e
+. ./tests/lib/test-setup.sh
 
-repo_dir="`mktemp -d`"
-repo="$repo_dir/repo"
-git init "$repo"
-(
-  cd "$repo"
-  echo Contents > test-file
-  git add test-file
-  git commit -m 'Commit message'
-)
-
-conf="`mktemp`"
-cat > "$conf" <<EOF
-[foo]
-git_repo = file://$repo
-git_ref = master
-EOF
+foo_setup
 
 python3 ./pinch.py pin "$conf"
 
@@ -32,7 +17,7 @@ python3 ./pinch.py pin "$conf"
 
 actual_env_command=`python3 ./pinch.py update --dry-run "$conf"`
 
-rm -rf "$repo_dir" "$conf"
+foo_cleanup
 
 expected_env_command_RE='^nix-env --profile /nix/var/nix/profiles/per-user/[^/]+/channels --show-trace --file '\''<nix/unpack-channel.nix>'\'' --install --from-expression '\''f: f \{ name = "(repo-[0-9]{10}-[0-9a-f]{11})"; channelName = "foo"; src = builtins.storePath "/nix/store/.{32}-\1.tar.xz"; \}'\''$'
 
diff --git a/tests/reject-duplicates.sh b/tests/reject-duplicates.sh
index d30bc40..8a630b0 100755
--- a/tests/reject-duplicates.sh
+++ b/tests/reject-duplicates.sh
@@ -1,50 +1,29 @@
 #!/bin/sh
 
-set -e
-
-repo_dir1="`mktemp -d`"
-repo1="$repo_dir1/repo"
-git init "$repo1"
-(
-  cd "$repo1"
-  echo Contents > test-file
-  git add test-file
-  git commit -m 'Commit message'
-)
-
-repo_dir2="`mktemp -d`"
-repo2="$repo_dir2/repo"
-git init "$repo2"
-(
-  cd "$repo2"
-  echo Contents > test-file
-  git add test-file
-  git commit -m 'Commit message'
-)
-
-conf1="`mktemp`"
-cat > "$conf1" <<EOF
-[same]
-git_repo = file://$repo1
-git_ref = master
-EOF
-
-conf2="`mktemp`"
-cat > "$conf2" <<EOF
-[same]
-git_repo = file://$repo2
-git_ref = master
-EOF
+. ./tests/lib/test-setup.sh
+
+foo_setup
+
+repo_dir1=$repo_dir
+repo1=$repo
+conf1=$conf
+
+foo_setup
 
 python3 ./pinch.py pin "$conf1"
-python3 ./pinch.py pin "$conf2"
+python3 ./pinch.py pin "$conf"
 
-if python3 ./pinch.py update --dry-run "$conf1" "$conf2";then
+if python3 ./pinch.py update --dry-run "$conf1" "$conf";then
   echo "FAIL: Duplicate names should be rejected"
   exit 1
 else
   echo PASS
 fi
 
-rm -rf "$repo_dir1" "$repo_dir2" "$conf1" "$conf2"
+foo_cleanup
+
+repo_dir=$repo_dir1
+repo=$repo1
+conf=$conf1
 
+foo_cleanup
diff --git a/tests/reject-nonancestor.sh b/tests/reject-nonancestor.sh
index b8e944a..5608761 100755
--- a/tests/reject-nonancestor.sh
+++ b/tests/reject-nonancestor.sh
@@ -1,23 +1,8 @@
 #!/bin/sh
 
-set -e
+. ./tests/lib/test-setup.sh
 
-repo_dir="`mktemp -d`"
-repo="$repo_dir/repo"
-git init "$repo"
-(
-  cd "$repo"
-  echo Contents > test-file
-  git add test-file
-  git commit -m 'Commit message'
-)
-
-conf="`mktemp`"
-cat > "$conf" <<EOF
-[foo]
-git_repo = file://$repo
-git_ref = master
-EOF
+foo_setup
 
 python3 ./pinch.py pin "$conf"
 
@@ -35,4 +20,4 @@ else
   echo PASS
 fi
 
-rm -rf "$repo_dir" "$conf"
+foo_cleanup
-- 
2.44.1