Use separate cache dir for test isolation

[pinch] / pinch.py

diff --git a/pinch.py b/pinch.py
index 5bb4e955d4f996ad7513533a579abba98d6e58e0..18272814951a1b2c5ce70374835766331522d8d2 100644 (file)
--- a/pinch.py
+++ b/pinch.py
@@ -7,8 +7,10 @@ import hashlib
 import operator
 import os
 import os.path
+import shlex
 import shutil
 import subprocess
+import sys
 import tempfile
 import types
 import urllib.parse
@@ -23,6 +25,9 @@ from typing import (
     Tuple,
 )
 
+import xdg
+
+
 Digest16 = NewType('Digest16', str)
 Digest32 = NewType('Digest32', str)
 
@@ -36,6 +41,7 @@ class ChannelTableEntry(types.SimpleNamespace):
 
 
 class Channel(types.SimpleNamespace):
+    alias_of: str
     channel_html: bytes
     channel_url: str
     forwarded_url: str
@@ -57,7 +63,7 @@ class Verification:
         self.line_length = 0
 
     def status(self, s: str) -> None:
-        print(s, end=' ', flush=True)
+        print(s, end=' ', file=sys.stderr, flush=True)
         self.line_length += 1 + len(s)  # Unicode??
 
     @staticmethod
@@ -69,7 +75,7 @@ class Verification:
         length = len(message)
         cols = shutil.get_terminal_size().columns
         pad = (cols - (self.line_length + length)) % cols
-        print(' ' * pad + self._color(message, color))
+        print(' ' * pad + self._color(message, color), file=sys.stderr)
         self.line_length = 0
         if not r:
             raise VerificationError()
@@ -213,9 +219,9 @@ def fetch_resources(v: Verification, channel: Channel) -> None:
 
 
 def git_cachedir(git_repo: str) -> str:
-    # TODO: Consider using pyxdg to find this path.
-    return os.path.expanduser(
-        '~/.cache/nix-pin-channel/git/%s' %
+    return os.path.join(
+        xdg.XDG_CACHE_HOME,
+        'pinch/git',
         digest_string(
             git_repo.encode()))
 
@@ -357,7 +363,8 @@ def git_checkout(v: Verification, channel: Channel, dest: str) -> None:
                            stdout=subprocess.PIPE)
     tar = subprocess.Popen(
         ['tar', 'x', '-C', dest, '-f', '-'], stdin=git.stdout)
-    git.stdout.close()
+    if git.stdout:
+        git.stdout.close()
     tar.wait()
     git.wait()
     v.result(git.returncode == 0 and tar.returncode == 0)
@@ -448,18 +455,30 @@ def git_revision_name(v: Verification, channel: Channel) -> str:
                               '--abbrev=11',
                               channel.git_revision],
                              capture_output=True)
-    v.result(process.returncode == 0 and process.stdout != '')
+    v.result(process.returncode == 0 and process.stdout != b'')
     return '%s-%s' % (os.path.basename(channel.git_repo),
                       process.stdout.decode().strip())
 
 
+def read_config(filename: str) -> configparser.ConfigParser:
+    config = configparser.ConfigParser()
+    config.read_file(open(filename), filename)
+    return config
+
+
 def pin(args: argparse.Namespace) -> None:
     v = Verification()
-    config = configparser.ConfigParser()
-    config.read_file(open(args.channels_file), args.channels_file)
+    config = read_config(args.channels_file)
     for section in config.sections():
+        if args.channels and section not in args.channels:
+            continue
 
         channel = Channel(**dict(config[section].items()))
+
+        if hasattr(channel, 'alias_of'):
+            assert not hasattr(channel, 'git_repo')
+            continue
+
         if hasattr(channel, 'git_revision'):
             channel.old_git_revision = channel.git_revision
             del channel.git_revision
@@ -481,34 +500,53 @@ def pin(args: argparse.Namespace) -> None:
 def update(args: argparse.Namespace) -> None:
     v = Verification()
     config = configparser.ConfigParser()
-    config.read_file(open(args.channels_file), args.channels_file)
-    exprs = []
-    for section in config.sections():
-        if 'channel_url' in config[section]:
-            tarball = fetch_with_nix_prefetch_url(
-                v, config[section]['tarball_url'], Digest16(
-                    config[section]['tarball_sha256']))
-        else:
-            channel = Channel(**dict(config[section].items()))
-            ensure_git_rev_available(v, channel)
-            tarball = git_get_tarball(v, channel)
-        exprs.append(
-            'f: f { name = "%s"; channelName = "%s"; src = builtins.storePath "%s"; }' %
-            (config[section]['release_name'], section, tarball))
-    v.status('Installing channels with nix-env')
-    process = subprocess.run(
-        [
-            'nix-env',
-            '--profile',
-            '/nix/var/nix/profiles/per-user/%s/channels' %
-            getpass.getuser(),
-            '--show-trace',
-            '--file',
-            '<nix/unpack-channel.nix>',
-            '--install',
-            '--from-expression'] +
-        exprs)
-    v.result(process.returncode == 0)
+    exprs: Dict[str, str] = {}
+    configs = [read_config(filename) for filename in args.channels_file]
+    for config in configs:
+        for section in config.sections():
+
+            if 'alias_of' in config[section]:
+                assert 'git_repo' not in config[section]
+                continue
+
+            if 'channel_url' in config[section]:
+                tarball = fetch_with_nix_prefetch_url(
+                    v, config[section]['tarball_url'], Digest16(
+                        config[section]['tarball_sha256']))
+            else:
+                channel = Channel(**dict(config[section].items()))
+                ensure_git_rev_available(v, channel)
+                tarball = git_get_tarball(v, channel)
+
+            if section in exprs:
+                raise Exception('Duplicate channel "%s"' % section)
+            exprs[section] = (
+                'f: f { name = "%s"; channelName = "%%s"; src = builtins.storePath "%s"; }' %
+                (config[section]['release_name'], tarball))
+
+    for config in configs:
+        for section in config.sections():
+            if 'alias_of' in config[section]:
+                if section in exprs:
+                    raise Exception('Duplicate channel "%s"' % section)
+                exprs[section] = exprs[str(config[section]['alias_of'])]
+
+    command = [
+        'nix-env',
+        '--profile',
+        '/nix/var/nix/profiles/per-user/%s/channels' %
+        getpass.getuser(),
+        '--show-trace',
+        '--file',
+        '<nix/unpack-channel.nix>',
+        '--install',
+        '--from-expression'] + [exprs[name] % name for name in sorted(exprs.keys())]
+    if args.dry_run:
+        print(' '.join(map(shlex.quote, command)))
+    else:
+        v.status('Installing channels with nix-env')
+        process = subprocess.run(command)
+        v.result(process.returncode == 0)
 
 
 def main() -> None:
@@ -516,9 +554,11 @@ def main() -> None:
     subparsers = parser.add_subparsers(dest='mode', required=True)
     parser_pin = subparsers.add_parser('pin')
     parser_pin.add_argument('channels_file', type=str)
+    parser_pin.add_argument('channels', type=str, nargs='*')
     parser_pin.set_defaults(func=pin)
     parser_update = subparsers.add_parser('update')
-    parser_update.add_argument('channels_file', type=str)
+    parser_update.add_argument('--dry-run', action='store_true')
+    parser_update.add_argument('channels_file', type=str, nargs='+')
     parser_update.set_defaults(func=update)
     args = parser.parse_args()
     args.func(args)