fetch: Multiple fetches per session

[paperdoorknob] / paperdoorknob_test.py

diff --git a/paperdoorknob_test.py b/paperdoorknob_test.py
index fafd1c37284c80486f0859aa33c39e0e2728153d..88897f4cd64937639ff723a5ae3432ab27caedbe 100644 (file)
--- a/paperdoorknob_test.py
+++ b/paperdoorknob_test.py
@@ -16,6 +16,9 @@ TIMEOUT = 8
 
 class FakeGlowficHTTPRequestHandler(BaseHTTPRequestHandler):
 
+    def _notify_test(self) -> None:
+        raise NotImplementedError()
+
     def _response_code(self) -> int:
         if self.path == "/not_found":
             return 404
@@ -30,28 +33,46 @@ class FakeGlowficHTTPRequestHandler(BaseHTTPRequestHandler):
         self.send_header("Content-Length", str(len(body)))
         self.end_headers()
         self.wfile.write(body)
+        self._notify_test()
 
 
 class TestFetch(unittest.TestCase):
+    def _port(self) -> int:
+        port = self._web_server.socket.getsockname()[1]
+        assert isinstance(port, int)
+        return port
+
+    def _count_request(self) -> None:
+        self._request_counter += 1
+
     def setUp(self) -> None:
-        web_server = HTTPServer(('', 0), FakeGlowficHTTPRequestHandler)
-        self._port = web_server.socket.getsockname()[1]
-        threading.Thread(target=web_server.serve_forever).start()
-        self._stop_server = web_server.shutdown
+        self._request_counter = 0
+        handler = type("Handler", (FakeGlowficHTTPRequestHandler,), {
+                       '_notify_test': lambda _: self._count_request()})
+        self._web_server = HTTPServer(('', 0), handler)
+        self._thread = threading.Thread(target=self._web_server.serve_forever)
+        self._thread.start()
 
     def tearDown(self) -> None:
-        self._stop_server()
+        self._web_server.shutdown()
+        self._thread.join()
+        self._web_server.server_close()
 
     def testFetch(self) -> None:
-        paperdoorknob.fetch(f"http://localhost:{self._port}", TIMEOUT)
+        with requests.session() as s:
+            paperdoorknob.fetch(f"http://localhost:{self._port()}", s, TIMEOUT)
+            self.assertEqual(self._request_counter, 1)
+            paperdoorknob.fetch(f"http://localhost:{self._port()}", s, TIMEOUT)
+            self.assertEqual(self._request_counter, 2)
 
     def testFetchErrors(self) -> None:
-        with self.assertRaises(requests.HTTPError):
-            paperdoorknob.fetch(
-                f"http://localhost:{self._port}/not_found", TIMEOUT)
-        with self.assertRaises(requests.HTTPError):
-            paperdoorknob.fetch(
-                f"http://localhost:{self._port}/server_error", TIMEOUT)
+        with requests.session() as s:
+            with self.assertRaises(requests.HTTPError):
+                paperdoorknob.fetch(
+                    f"http://localhost:{self._port()}/not_found", s, TIMEOUT)
+            with self.assertRaises(requests.HTTPError):
+                paperdoorknob.fetch(
+                    f"http://localhost:{self._port()}/server_error", s, TIMEOUT)
 
 
 if __name__ == '__main__':