Fix flaky test: Increment request count before responding

[paperdoorknob] / images_test.py

# paperdoorknob: Print glowfic
#
# This program is free software: you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by the
# Free Software Foundation, version 3.


import unittest

from fetch import FakeFetcher
from images import DiskImageStore


class TestImageStore(unittest.TestCase):
    def setUp(self) -> None:
        self._fetcher = FakeFetcher({
            'https://example.com/images/alice.png': b'ALICE',
            'https://example.com/images/bob.jpeg': b'BOB',
            'https://example.com/alt_images/bob.jpeg': b'BOBBY',
            'https://example.com/images/carol': b'CAROL',
            'https://example.com/alt_images/carol': b'CAROLINE',
            'https://example.com/other_images/carol': b'CAROLINA'})

    def testFetchOnce(self) -> None:
        store = DiskImageStore('istest_fetch_once', self._fetcher)
        self.assertEqual(self._fetcher.request_count(), 0)
        a1 = store.get_image('https://example.com/images/alice.png')
        self.assertEqual(self._fetcher.request_count(), 1)
        a2 = store.get_image('https://example.com/images/alice.png')
        self.assertEqual(self._fetcher.request_count(), 1)
        self.assertEqual(a1, a2)
        self.assertEqual(a1, 'istest_fetch_once/alice.png')
        with open(a1, 'rb') as f:
            self.assertEqual(f.read(), b'ALICE')

        self.assertEqual(self._fetcher.request_count(), 1)
        b1 = store.get_image('https://example.com/images/bob.jpeg')
        self.assertEqual(self._fetcher.request_count(), 2)
        b2 = store.get_image('https://example.com/images/bob.jpeg')
        self.assertEqual(self._fetcher.request_count(), 2)
        self.assertEqual(b1, b2)
        self.assertEqual(b1, 'istest_fetch_once/bob.jpeg')
        with open(b1, 'rb') as f:
            self.assertEqual(f.read(), b'BOB')

        a3 = store.get_image('https://example.com/images/alice.png')
        self.assertEqual(self._fetcher.request_count(), 2)
        self.assertEqual(a1, a3)

    def testNameCollision(self) -> None:
        store = DiskImageStore('istest_name_collision', self._fetcher)
        self.assertEqual(self._fetcher.request_count(), 0)
        b1 = store.get_image('https://example.com/images/bob.jpeg')
        self.assertEqual(self._fetcher.request_count(), 1)
        b2 = store.get_image('https://example.com/alt_images/bob.jpeg')
        self.assertEqual(self._fetcher.request_count(), 2)
        self.assertNotEqual(b1, b2)
        self.assertEqual(b1, 'istest_name_collision/bob.jpeg')
        self.assertEqual(b2, 'istest_name_collision/bob-0000.jpeg')
        with open(b1, 'rb') as f:
            self.assertEqual(f.read(), b'BOB')
        with open(b2, 'rb') as f:
            self.assertEqual(f.read(), b'BOBBY')

        self.assertEqual(self._fetcher.request_count(), 2)
        c1 = store.get_image('https://example.com/images/carol')
        self.assertEqual(self._fetcher.request_count(), 3)
        c2 = store.get_image('https://example.com/alt_images/carol')
        self.assertEqual(self._fetcher.request_count(), 4)
        c3 = store.get_image('https://example.com/other_images/carol')
        self.assertEqual(self._fetcher.request_count(), 5)
        self.assertNotEqual(c1, c2)
        self.assertNotEqual(c2, c3)
        self.assertNotEqual(c1, c3)
        self.assertEqual(c1, 'istest_name_collision/carol')
        self.assertEqual(c2, 'istest_name_collision/carol-0000')
        self.assertEqual(c3, 'istest_name_collision/carol-0001')
        with open(c1, 'rb') as f:
            self.assertEqual(f.read(), b'CAROL')
        with open(c2, 'rb') as f:
            self.assertEqual(f.read(), b'CAROLINE')
        with open(c3, 'rb') as f:
            self.assertEqual(f.read(), b'CAROLINA')


if __name__ == '__main__':
    unittest.main()