Explicitly bounds-check in angle_between()

[nt3d] / nt3d.js

diff --git a/nt3d.js b/nt3d.js
index 3ce05be192449917990be333d3a0b8a6621b6c17..038994678f9328de72fca780f4a8b639a58e915b 100644 (file)
--- a/nt3d.js
+++ b/nt3d.js
@@ -259,7 +259,14 @@ nt3d = {
                        point[2] + offset[2]];
        },
        angle_between: function(a, b) { // a and b must be unit vectors
                        point[2] + offset[2]];
        },
        angle_between: function(a, b) { // a and b must be unit vectors

-               return Math.acos(this.dot(a, b));
+               var the_dot = this.dot(a, b);
+               if (the_dot <= -1) {
+                       return Math.PI;
+               }
+               if (the_dot >= 1) {
+                       return 0;
+               }
+               return Math.acos(the_dot);

        },
        rotate_about_origin: function(points, axis, angle) { // axis must be a unit vector
                // From http://inside.mines.edu/~gmurray/ArbitraryAxisRotation/
        },
        rotate_about_origin: function(points, axis, angle) { // axis must be a unit vector
                // From http://inside.mines.edu/~gmurray/ArbitraryAxisRotation/


@@ -353,7 +360,7 @@ nt3d = {
                        if (nan_in_face) nan_face_count ++;
                }
                if (nan_count != 0) {
                        if (nan_in_face) nan_face_count ++;
                }
                if (nan_count != 0) {

-                       alert(nan_count + " NaNs in " + nan_point_count + " points in " + nan_face_count + " faces.");
+                       alert(nan_count + " NaNs in " + nan_point_count + " points in " + nan_face_count + " faces (" + (100 * nan_face_count / (this.points.length/3)) + "% of faces).");

                }
 
                // Remove degenerate faces
                }
 
                // Remove degenerate faces